From: yang.shi@linaro.org (Shi, Yang)
To: linux-arm-kernel@lists.infradead.org
Subject: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it
Date: Tue, 10 Nov 2015 08:51:06 -0800 [thread overview]
Message-ID: <5642207A.9070406@linaro.org> (raw)
In-Reply-To: <20151110103752.GH21606@e104818-lin.cambridge.arm.com>
On 11/10/2015 2:37 AM, Catalin Marinas wrote:
> On Mon, Nov 09, 2015 at 10:09:55AM -0800, Yang Shi wrote:
>> FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine
>> it in arch/arm64/Kconfig.debug. Actually, the one defined in arm64 directory
>> is never used.
>
> That's not true since the arm64 definition seems to take precedence.
>
>> This adds a dependency on DEBUG_KERNEL for building with frame pointers.
>
> It doesn't because arm64 selects ARCH_WANT_FRAME_POINTERS.
Thanks for pointing it out. I misread the order of precedence, still
think of C syntax at the first place.
Yang
>
>> ARM64 depends on frame pointer to get correct stack backtrace and need
>> FRAME_POINTER kconfig option enabled all the time.
>> However, currect implementation makes it could be disabled, so force it
>> to be selected by ARM64.
>>
>> Signed-off-by: Yang Shi <yang.shi@linaro.org>
>
> Patch applied but I changed the commit log slightly. Thanks.
>
prev parent reply other threads:[~2015-11-10 16:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 18:09 [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it Yang Shi
2015-11-10 10:37 ` Catalin Marinas
2015-11-10 11:09 ` yalin wang
2015-11-10 11:35 ` Catalin Marinas
2015-11-10 11:43 ` yalin wang
2015-11-10 11:54 ` Will Deacon
2015-11-10 16:51 ` Shi, Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5642207A.9070406@linaro.org \
--to=yang.shi@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).