* [PATCH 1/4] arm: omap2+: add missing HWMOD_NO_IDLEST in 81xx hwmod data @ 2015-10-22 9:18 Neil Armstrong 2015-10-24 1:21 ` Tony Lindgren 0 siblings, 1 reply; 6+ messages in thread From: Neil Armstrong @ 2015-10-22 9:18 UTC (permalink / raw) To: linux-arm-kernel Add missing HWMOD_NO_IDLEST hwmod flag for entries no having omap4 clkctrl values. Cc: Brian Hutchinson <b.hutchman@gmail.com> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c index b1288f5..6256052 100644 --- a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c @@ -144,6 +144,7 @@ static struct omap_hwmod dm81xx_l4_ls_hwmod = { .name = "l4_ls", .clkdm_name = "alwon_l3s_clkdm", .class = &l4_hwmod_class, + .flags = HWMOD_NO_IDLEST, }; /* @@ -155,6 +156,7 @@ static struct omap_hwmod dm81xx_l4_hs_hwmod = { .name = "l4_hs", .clkdm_name = "alwon_l3_med_clkdm", .class = &l4_hwmod_class, + .flags = HWMOD_NO_IDLEST, }; /* L3 slow -> L4 ls peripheral interface running at 125MHz */ @@ -850,6 +852,7 @@ static struct omap_hwmod dm816x_emac0_hwmod = { .name = "emac0", .clkdm_name = "alwon_ethernet_clkdm", .class = &dm816x_emac_hwmod_class, + .flags = HWMOD_NO_IDLEST, }; static struct omap_hwmod_ocp_if dm81xx_l4_hs__emac0 = { -- 1.9.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/4] arm: omap2+: add missing HWMOD_NO_IDLEST in 81xx hwmod data 2015-10-22 9:18 [PATCH 1/4] arm: omap2+: add missing HWMOD_NO_IDLEST in 81xx hwmod data Neil Armstrong @ 2015-10-24 1:21 ` Tony Lindgren 2015-10-24 10:09 ` Neil Armstrong 0 siblings, 1 reply; 6+ messages in thread From: Tony Lindgren @ 2015-10-24 1:21 UTC (permalink / raw) To: linux-arm-kernel Hi, * Neil Armstrong <narmstrong@baylibre.com> [151022 02:19]: > Add missing HWMOD_NO_IDLEST hwmod flag for entries no > having omap4 clkctrl values. Have you checked this is the case both in dm814x and dm816x TRM? Also the documentation may not be complete FYI, might be also worth checking the legacy TI kernel tree to be sure. Regards, Tony > Cc: Brian Hutchinson <b.hutchman@gmail.com> > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > --- > arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c > index b1288f5..6256052 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c > @@ -144,6 +144,7 @@ static struct omap_hwmod dm81xx_l4_ls_hwmod = { > .name = "l4_ls", > .clkdm_name = "alwon_l3s_clkdm", > .class = &l4_hwmod_class, > + .flags = HWMOD_NO_IDLEST, > }; > > /* > @@ -155,6 +156,7 @@ static struct omap_hwmod dm81xx_l4_hs_hwmod = { > .name = "l4_hs", > .clkdm_name = "alwon_l3_med_clkdm", > .class = &l4_hwmod_class, > + .flags = HWMOD_NO_IDLEST, > }; > > /* L3 slow -> L4 ls peripheral interface running at 125MHz */ > @@ -850,6 +852,7 @@ static struct omap_hwmod dm816x_emac0_hwmod = { > .name = "emac0", > .clkdm_name = "alwon_ethernet_clkdm", > .class = &dm816x_emac_hwmod_class, > + .flags = HWMOD_NO_IDLEST, > }; > > static struct omap_hwmod_ocp_if dm81xx_l4_hs__emac0 = { > -- > 1.9.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/4] arm: omap2+: add missing HWMOD_NO_IDLEST in 81xx hwmod data 2015-10-24 1:21 ` Tony Lindgren @ 2015-10-24 10:09 ` Neil Armstrong 2015-11-12 14:15 ` Neil Armstrong 0 siblings, 1 reply; 6+ messages in thread From: Neil Armstrong @ 2015-10-24 10:09 UTC (permalink / raw) To: linux-arm-kernel Hi, 2015-10-24 3:21 GMT+02:00 Tony Lindgren <tony@atomide.com>: > > Hi, > > * Neil Armstrong <narmstrong@baylibre.com> [151022 02:19]: > > Add missing HWMOD_NO_IDLEST hwmod flag for entries no > > having omap4 clkctrl values. > > Have you checked this is the case both in dm814x and dm816x TRM? > Also the documentation may not be complete FYI, might be also > worth checking the legacy TI kernel tree to be sure. > > Regards, > > Tony > > > Cc: Brian Hutchinson <b.hutchman@gmail.com> > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > > --- > > arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c > > index b1288f5..6256052 100644 > > --- a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c > > +++ b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c > > @@ -144,6 +144,7 @@ static struct omap_hwmod dm81xx_l4_ls_hwmod = { > > .name = "l4_ls", > > .clkdm_name = "alwon_l3s_clkdm", > > .class = &l4_hwmod_class, > > + .flags = HWMOD_NO_IDLEST, > > }; In DM814x TRM, the CM_ALWON_L3_SLOW_CLKSTCTRL does not have IDLEST field. Same in DM816x TRM. > > > > /* > > @@ -155,6 +156,7 @@ static struct omap_hwmod dm81xx_l4_hs_hwmod = { > > .name = "l4_hs", > > .clkdm_name = "alwon_l3_med_clkdm", > > .class = &l4_hwmod_class, > > + .flags = HWMOD_NO_IDLEST, > > }; In DM814x TRM, the CM_ALWON_L3_MED_CLKSTCTRL does not have IDLEST field. Same in DM816x TRM. > > > > /* L3 slow -> L4 ls peripheral interface running at 125MHz */ > > @@ -850,6 +852,7 @@ static struct omap_hwmod dm816x_emac0_hwmod = { > > .name = "emac0", > > .clkdm_name = "alwon_ethernet_clkdm", > > .class = &dm816x_emac_hwmod_class, > > + .flags = HWMOD_NO_IDLEST, > > }; In this particular case, the IDLEST is handled in the MDIO hwmod. > > > > static struct omap_hwmod_ocp_if dm81xx_l4_hs__emac0 = { > > -- > > 1.9.1 I'll check the TI tree to be sure... Regards, Neil ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/4] arm: omap2+: add missing HWMOD_NO_IDLEST in 81xx hwmod data 2015-10-24 10:09 ` Neil Armstrong @ 2015-11-12 14:15 ` Neil Armstrong 2015-11-13 14:41 ` Tony Lindgren 0 siblings, 1 reply; 6+ messages in thread From: Neil Armstrong @ 2015-11-12 14:15 UTC (permalink / raw) To: linux-arm-kernel On 10/24/2015 12:09 PM, Neil Armstrong wrote: > Hi, > > 2015-10-24 3:21 GMT+02:00 Tony Lindgren <tony@atomide.com>: >> >> Hi, >> >> * Neil Armstrong <narmstrong@baylibre.com> [151022 02:19]: >>> Add missing HWMOD_NO_IDLEST hwmod flag for entries no >>> having omap4 clkctrl values. >> >> Have you checked this is the case both in dm814x and dm816x TRM? >> Also the documentation may not be complete FYI, might be also >> worth checking the legacy TI kernel tree to be sure. >> >> Regards, >> >> Tony >> >>> Cc: Brian Hutchinson <b.hutchman@gmail.com> >>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> >>> --- >>> arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c >>> index b1288f5..6256052 100644 >>> --- a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c >>> +++ b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c >>> @@ -144,6 +144,7 @@ static struct omap_hwmod dm81xx_l4_ls_hwmod = { >>> .name = "l4_ls", >>> .clkdm_name = "alwon_l3s_clkdm", >>> .class = &l4_hwmod_class, >>> + .flags = HWMOD_NO_IDLEST, >>> }; > In DM814x TRM, the CM_ALWON_L3_SLOW_CLKSTCTRL does not have IDLEST field. > Same in DM816x TRM. > >>> >>> /* >>> @@ -155,6 +156,7 @@ static struct omap_hwmod dm81xx_l4_hs_hwmod = { >>> .name = "l4_hs", >>> .clkdm_name = "alwon_l3_med_clkdm", >>> .class = &l4_hwmod_class, >>> + .flags = HWMOD_NO_IDLEST, >>> }; > In DM814x TRM, the CM_ALWON_L3_MED_CLKSTCTRL does not have IDLEST field. > Same in DM816x TRM. > >>> >>> /* L3 slow -> L4 ls peripheral interface running at 125MHz */ >>> @@ -850,6 +852,7 @@ static struct omap_hwmod dm816x_emac0_hwmod = { >>> .name = "emac0", >>> .clkdm_name = "alwon_ethernet_clkdm", >>> .class = &dm816x_emac_hwmod_class, >>> + .flags = HWMOD_NO_IDLEST, >>> }; > In this particular case, the IDLEST is handled in the MDIO hwmod. > >>> >>> static struct omap_hwmod_ocp_if dm81xx_l4_hs__emac0 = { >>> -- >>> 1.9.1 > > I'll check the TI tree to be sure... > > Regards, > Neil > Tony, In TI's tree, there is no L3_MED hwmod but the L3_SLOW hwmod has NO_IDLEST flag. Is there any other issue about this patchset ? Neil ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/4] arm: omap2+: add missing HWMOD_NO_IDLEST in 81xx hwmod data 2015-11-12 14:15 ` Neil Armstrong @ 2015-11-13 14:41 ` Tony Lindgren 2015-11-13 16:18 ` Neil Armstrong 0 siblings, 1 reply; 6+ messages in thread From: Tony Lindgren @ 2015-11-13 14:41 UTC (permalink / raw) To: linux-arm-kernel * Neil Armstrong <narmstrong@baylibre.com> [151112 06:16]: > On 10/24/2015 12:09 PM, Neil Armstrong wrote: > > Hi, > > > > 2015-10-24 3:21 GMT+02:00 Tony Lindgren <tony@atomide.com>: > >> > >> Hi, > >> > >> * Neil Armstrong <narmstrong@baylibre.com> [151022 02:19]: > >>> Add missing HWMOD_NO_IDLEST hwmod flag for entries no > >>> having omap4 clkctrl values. > >> > >> Have you checked this is the case both in dm814x and dm816x TRM? > >> Also the documentation may not be complete FYI, might be also > >> worth checking the legacy TI kernel tree to be sure. > >> > >> Regards, > >> > >> Tony > >> > >>> Cc: Brian Hutchinson <b.hutchman@gmail.com> > >>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > >>> --- > >>> arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 3 +++ > >>> 1 file changed, 3 insertions(+) > >>> > >>> diff --git a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c > >>> index b1288f5..6256052 100644 > >>> --- a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c > >>> +++ b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c > >>> @@ -144,6 +144,7 @@ static struct omap_hwmod dm81xx_l4_ls_hwmod = { > >>> .name = "l4_ls", > >>> .clkdm_name = "alwon_l3s_clkdm", > >>> .class = &l4_hwmod_class, > >>> + .flags = HWMOD_NO_IDLEST, > >>> }; > > In DM814x TRM, the CM_ALWON_L3_SLOW_CLKSTCTRL does not have IDLEST field. > > Same in DM816x TRM. > > > >>> > >>> /* > >>> @@ -155,6 +156,7 @@ static struct omap_hwmod dm81xx_l4_hs_hwmod = { > >>> .name = "l4_hs", > >>> .clkdm_name = "alwon_l3_med_clkdm", > >>> .class = &l4_hwmod_class, > >>> + .flags = HWMOD_NO_IDLEST, > >>> }; > > In DM814x TRM, the CM_ALWON_L3_MED_CLKSTCTRL does not have IDLEST field. > > Same in DM816x TRM. > > > >>> > >>> /* L3 slow -> L4 ls peripheral interface running at 125MHz */ > >>> @@ -850,6 +852,7 @@ static struct omap_hwmod dm816x_emac0_hwmod = { > >>> .name = "emac0", > >>> .clkdm_name = "alwon_ethernet_clkdm", > >>> .class = &dm816x_emac_hwmod_class, > >>> + .flags = HWMOD_NO_IDLEST, > >>> }; > > In this particular case, the IDLEST is handled in the MDIO hwmod. > > > >>> > >>> static struct omap_hwmod_ocp_if dm81xx_l4_hs__emac0 = { > >>> -- > >>> 1.9.1 > > > > I'll check the TI tree to be sure... > > > > Regards, > > Neil > > > Tony, > > In TI's tree, there is no L3_MED hwmod but the L3_SLOW hwmod has NO_IDLEST flag. > > Is there any other issue about this patchset ? Thanks for checking. Well one thing, if this is needed as fix, then a description of what happens without it would be good to have. Regards, Tony ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/4] arm: omap2+: add missing HWMOD_NO_IDLEST in 81xx hwmod data 2015-11-13 14:41 ` Tony Lindgren @ 2015-11-13 16:18 ` Neil Armstrong 0 siblings, 0 replies; 6+ messages in thread From: Neil Armstrong @ 2015-11-13 16:18 UTC (permalink / raw) To: linux-arm-kernel On 11/13/2015 03:41 PM, Tony Lindgren wrote: > * Neil Armstrong <narmstrong@baylibre.com> [151112 06:16]: >> On 10/24/2015 12:09 PM, Neil Armstrong wrote: >>> Hi, >>> >>> 2015-10-24 3:21 GMT+02:00 Tony Lindgren <tony@atomide.com>: >>>> >>>> Hi, >>>> >>>> * Neil Armstrong <narmstrong@baylibre.com> [151022 02:19]: >>>>> Add missing HWMOD_NO_IDLEST hwmod flag for entries no >>>>> having omap4 clkctrl values. >>>> >>>> Have you checked this is the case both in dm814x and dm816x TRM? >>>> Also the documentation may not be complete FYI, might be also >>>> worth checking the legacy TI kernel tree to be sure. >>>> >>>> Regards, >>>> >>>> Tony >>>> >>>>> Cc: Brian Hutchinson <b.hutchman@gmail.com> >>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> >>>>> --- >>>>> arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 3 +++ >>>>> 1 file changed, 3 insertions(+) >>>>> >>>>> diff --git a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c >>>>> index b1288f5..6256052 100644 >>>>> --- a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c >>>>> +++ b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c >>>>> @@ -144,6 +144,7 @@ static struct omap_hwmod dm81xx_l4_ls_hwmod = { >>>>> .name = "l4_ls", >>>>> .clkdm_name = "alwon_l3s_clkdm", >>>>> .class = &l4_hwmod_class, >>>>> + .flags = HWMOD_NO_IDLEST, >>>>> }; >>> In DM814x TRM, the CM_ALWON_L3_SLOW_CLKSTCTRL does not have IDLEST field. >>> Same in DM816x TRM. >>> >>>>> >>>>> /* >>>>> @@ -155,6 +156,7 @@ static struct omap_hwmod dm81xx_l4_hs_hwmod = { >>>>> .name = "l4_hs", >>>>> .clkdm_name = "alwon_l3_med_clkdm", >>>>> .class = &l4_hwmod_class, >>>>> + .flags = HWMOD_NO_IDLEST, >>>>> }; >>> In DM814x TRM, the CM_ALWON_L3_MED_CLKSTCTRL does not have IDLEST field. >>> Same in DM816x TRM. >>> >>>>> >>>>> /* L3 slow -> L4 ls peripheral interface running at 125MHz */ >>>>> @@ -850,6 +852,7 @@ static struct omap_hwmod dm816x_emac0_hwmod = { >>>>> .name = "emac0", >>>>> .clkdm_name = "alwon_ethernet_clkdm", >>>>> .class = &dm816x_emac_hwmod_class, >>>>> + .flags = HWMOD_NO_IDLEST, >>>>> }; >>> In this particular case, the IDLEST is handled in the MDIO hwmod. >>> >>>>> >>>>> static struct omap_hwmod_ocp_if dm81xx_l4_hs__emac0 = { >>>>> -- >>>>> 1.9.1 >>> >>> I'll check the TI tree to be sure... >>> >>> Regards, >>> Neil >>> >> Tony, >> >> In TI's tree, there is no L3_MED hwmod but the L3_SLOW hwmod has NO_IDLEST flag. >> >> Is there any other issue about this patchset ? > > Thanks for checking. Well one thing, if this is needed as fix, then a > description of what happens without it would be good to have. > > Regards, > > Tony > Tony, I'll send a patchset with the error lines in a few minutes. Neil ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-11-13 16:18 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-10-22 9:18 [PATCH 1/4] arm: omap2+: add missing HWMOD_NO_IDLEST in 81xx hwmod data Neil Armstrong 2015-10-24 1:21 ` Tony Lindgren 2015-10-24 10:09 ` Neil Armstrong 2015-11-12 14:15 ` Neil Armstrong 2015-11-13 14:41 ` Tony Lindgren 2015-11-13 16:18 ` Neil Armstrong
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).