linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: yang.shi@linaro.org (Shi, Yang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm64: bpf: add 'store immediate' instruction
Date: Thu, 12 Nov 2015 11:33:15 -0800	[thread overview]
Message-ID: <5644E97B.6050203@linaro.org> (raw)
In-Reply-To: <20151111123955.GK9562@arm.com>

On 11/11/2015 4:39 AM, Will Deacon wrote:
> On Wed, Nov 11, 2015 at 12:12:56PM +0000, Will Deacon wrote:
>> On Tue, Nov 10, 2015 at 06:45:39PM -0800, Z Lim wrote:
>>> On Tue, Nov 10, 2015 at 2:41 PM, Yang Shi <yang.shi@linaro.org> wrote:
>>>> aarch64 doesn't have native store immediate instruction, such operation
>>>
>>> Actually, aarch64 does have "STR (immediate)". For arm64 JIT, we can
>>> consider using it as an optimization.
>>
>> Yes, I'd definitely like to see that in preference to moving via a
>> temporary register.
>
> Wait a second, we're both talking rubbish here :) The STR (immediate)
> form is referring to the addressing mode, whereas this patch wants to
> store an immediate value to memory, which does need moving to a register
> first.

Yes, the immediate means immediate offset for addressing index. Doesn't 
mean to store immediate to memory.

I don't think any load-store architecture has store immediate instruction.

Thanks,
Yang

>
> So the original patch is fine.
>
> Will
>

  reply	other threads:[~2015-11-12 19:33 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-10 22:41 [PATCH 0/2] arm64: bpf: add BPF_ST and BPF_XADD instructions support Yang Shi
2015-11-10 22:41 ` [PATCH 1/2] arm64: bpf: add 'store immediate' instruction Yang Shi
2015-11-11  2:45   ` Z Lim
2015-11-11 12:12     ` Will Deacon
2015-11-11 12:39       ` Will Deacon
2015-11-12 19:33         ` Shi, Yang [this message]
2015-11-13  3:45           ` Z Lim
2015-11-23 19:34             ` Shi, Yang
2015-11-10 22:41 ` [PATCH 2/2] arm64: bpf: add BPF XADD instruction Yang Shi
2015-11-11  0:08   ` Eric Dumazet
2015-11-11  0:26     ` Shi, Yang
2015-11-11  0:42       ` Alexei Starovoitov
2015-11-11  2:52         ` Z Lim
2015-11-11  8:49           ` Arnd Bergmann
2015-11-11 10:24             ` Will Deacon
2015-11-11 10:42               ` Daniel Borkmann
2015-11-11 11:58                 ` Will Deacon
2015-11-11 12:21                   ` Daniel Borkmann
2015-11-11 12:38                     ` Will Deacon
2015-11-11 12:58                       ` Peter Zijlstra
2015-11-11 15:52                         ` Daniel Borkmann
2015-11-11 16:23                           ` Will Deacon
2015-11-11 17:27                             ` Alexei Starovoitov
2015-11-11 17:35                               ` David Miller
2015-11-11 17:44                                 ` Will Deacon
2015-11-11 19:01                                   ` David Miller
2015-11-11 17:57                                 ` Peter Zijlstra
2015-11-11 18:11                                   ` Alexei Starovoitov
2015-11-11 18:31                                     ` Peter Zijlstra
2015-11-11 18:41                                       ` Peter Zijlstra
2015-11-11 18:44                                       ` Peter Zijlstra
2015-11-11 18:54                                         ` Peter Zijlstra
2015-11-11 19:55                                           ` Alexei Starovoitov
2015-11-11 22:21                                             ` Peter Zijlstra
2015-11-11 23:40                                               ` Alexei Starovoitov
2015-11-12  8:57                                                 ` Peter Zijlstra
2015-11-11 18:50                                       ` Daniel Borkmann
2015-11-11 19:04                                         ` David Miller
2015-11-11 19:23                                         ` Peter Zijlstra
2015-11-11 19:41                                           ` Daniel Borkmann
2015-11-11 18:46                                     ` Will Deacon
2015-11-11 19:01                                     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5644E97B.6050203@linaro.org \
    --to=yang.shi@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).