From: grygorii.strashko@ti.com (Grygorii Strashko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP4: execute initcall to reserve SRAM for I688 only on OMAP4
Date: Mon, 16 Nov 2015 14:24:54 +0200 [thread overview]
Message-ID: <5649CB16.2030706@ti.com> (raw)
In-Reply-To: <1447673117-32719-1-git-send-email-l.stach@pengutronix.de>
On 11/16/2015 01:25 PM, Lucas Stach wrote:
> omap_interconnect_sync() is the only user of the SRAM scratch area
> allocated in the omap4_sram_init initcall. The interconnect sync is
> used exclusively in the OMAP4 specific WFI implementation, so there
> is no point in allocating the SRAM scratch on other SoC types.
>
> Bail out of the initcall if the kernel is not running on OMAP4 to
> avoid a confusing warning about being unable to allocate the SRAM
> needed for I688 handling.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> Tested-by: Bastian Stender <bst@pengutronix.de>
> ---
> arch/arm/mach-omap2/omap4-common.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c
> index 949696b6f17b..6db393a30a28 100644
> --- a/arch/arm/mach-omap2/omap4-common.c
> +++ b/arch/arm/mach-omap2/omap4-common.c
> @@ -131,6 +131,9 @@ static int __init omap4_sram_init(void)
> struct device_node *np;
> struct gen_pool *sram_pool;
>
> + if (!cpu_is_omap44xx())
> + return 0;
This one affects on am43xx also
> +
> np = of_find_compatible_node(NULL, NULL, "ti,omap4-mpu");
> if (!np)
> pr_warn("%s:Unable to allocate sram needed to handle errata I688\n",
Since all OMAP4+ platforms are now DT based why can't we just return from here silently?
--
regards,
-grygorii
next prev parent reply other threads:[~2015-11-16 12:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 11:25 [PATCH] ARM: OMAP4: execute initcall to reserve SRAM for I688 only on OMAP4 Lucas Stach
2015-11-16 12:24 ` Grygorii Strashko [this message]
2015-11-30 17:27 ` Lucas Stach
2015-11-30 18:27 ` Grygorii Strashko
2015-12-01 11:16 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5649CB16.2030706@ti.com \
--to=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).