From: xobs@kosagi.com (Sean Cross)
To: linux-arm-kernel@lists.infradead.org
Subject: Freescale IMX6 active cooling
Date: Wed, 18 Nov 2015 12:53:39 +0800 [thread overview]
Message-ID: <564C0453.6020400@kosagi.com> (raw)
In-Reply-To: <CABH3fy-QPV1bv-WaO3mWVq2RN5=f-AnBHMgFTmmU-Ve3xgyUrw@mail.gmail.com>
On 17/11/2015 8:49 PM, Catalin Crenguta wrote:
> On Tue, Nov 17, 2015 at 11:38 AM, Jon Nettleton <jon.nettleton@gmail.com> wrote:
>> I would recommend you take a look at the work that xobs did for the
>> Novena Heirloom. If you look at this branch starting around Aug 3 you
>> can see where he has converted iMX6 to use generic thermal zones and
>> adds support for for an active cooling device/fan.
>> https://github.com/xobs/novena-linux/commits/v3.19-novena-etnadrm-r3?page=3
>>
>> -Jon
> Thank you!
> I have patched my 4.3 kernel (they don't apply cleanly but they are
> straight forward to modify), added a gpio-fan and the corresponding
> thermal-zone in my DTB and it works!
> Sean Cross, are you interested in bringing this to mainline?
Yes, this does seem like the sort of thing that should make it into
mainline.
Would you like me to submit it as a patch against 4.3? I'm unclear how
much should be added.
For example, the current code talks directly to the cpufreq cooling
system, but that becomes unnecessary if using generic thermal zones,
since the zones will bind cpufreq to the thermal sensor. Then again,
with such a patch, boards that do not explicitly update their device
tree to support generic thermal zones will need to have their entries
updated.
Perhaps the correct order of patches is:
1) Add generic thermal zone support
2) Remove zone and cdev from imx_thermal
3) Add cpufreq-cooling to imx6
4) Add cpufreq-cooling to all other SoCs that support imx_thermal
5) Add default generic thermal zone support to imx6qdl.dtsi
Comments on how it should be handled?
Sean
next prev parent reply other threads:[~2015-11-18 4:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 9:43 Freescale IMX6 active cooling Catalin Crenguta
2015-11-16 14:51 ` Fabio Estevam
2015-11-17 9:38 ` Jon Nettleton
2015-11-17 12:49 ` Catalin Crenguta
2015-11-18 4:53 ` Sean Cross [this message]
2015-11-18 10:00 ` Catalin Crenguta
2015-11-18 21:56 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564C0453.6020400@kosagi.com \
--to=xobs@kosagi.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).