From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm64: EXYNOS: Consolidate ARCH_EXYNOS7 symbol into ARCH_EXYNOS
Date: Thu, 19 Nov 2015 13:36:43 +0900 [thread overview]
Message-ID: <564D51DB.1040904@samsung.com> (raw)
In-Reply-To: <CA+Ln22FP60Zc4cQmztNTy+2ZbhE1T7pgPXBMb9T=YZcYPo0EdA@mail.gmail.com>
On 19.11.2015 13:23, Tomasz Figa wrote:
> Hi Krzysztof,
>
> 2015-11-16 10:36 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>:
>> The ARMv8 Exynos family SoCs in Linux kernel are currently:
>> - Exynos5433 (controlled by ARCH_EXYNOS),
>> - Exynos7 (controlled by ARCH_EXYNOS7).
>>
>> It duplicates Kconfig symbols unnecessarily, so consolidate them into
>> one ARCH_EXYNOS. Future SoCs could fall also under the ARCH_EXYNOS
>> symbol.
>>
>> The commit should not bring any visible functional change.
>
> I think this basically matches the general recommendation for ARM64,
> so excluding the single nitpick inline and assuming that, after this
> patch, grep ARCH_EXYNOS7 gives no results:
>
> Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com>
>
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> ---
>> arch/arm64/Kconfig.platforms | 11 ++---------
>> arch/arm64/boot/dts/exynos/Makefile | 2 +-
>> arch/arm64/configs/defconfig | 2 +-
>> 3 files changed, 4 insertions(+), 11 deletions(-)
>>
>> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
>> index 4043c35962cc..afa19baca94e 100644
>> --- a/arch/arm64/Kconfig.platforms
>> +++ b/arch/arm64/Kconfig.platforms
>> @@ -13,21 +13,14 @@ config ARCH_BERLIN
>> This enables support for Marvell Berlin SoC Family
>>
>> config ARCH_EXYNOS
>> - bool
>> - help
>> - This enables support for Samsung Exynos SoC family
>> -
>> -config ARCH_EXYNOS7
>> - bool "ARMv8 based Samsung Exynos7"
>> - select ARCH_EXYNOS
>> + bool "ARMv8 based Samsung Exynos SoC family"
>> select COMMON_CLK_SAMSUNG
>> select HAVE_S3C2410_WATCHDOG if WATCHDOG
>> select HAVE_S3C_RTC if RTC_CLASS
>> select PINCTRL
>> select PINCTRL_EXYNOS
>> -
>> help
>> - This enables support for Samsung Exynos7 SoC family
>> + This enables support for Samsung Exynos ARMv8 SoC family
>
> nit: Sounds a little bit strange. Maybe "This enables support for
> ARMv8 based Samsung Exynos SoC family"?
Sure, sounds better.
Thanks for feedback!
BR,
Krzysztof
prev parent reply other threads:[~2015-11-19 4:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 1:36 [PATCH 0/2] arm64: EXYNOS: Consolidate Exynos7 symbol Krzysztof Kozlowski
2015-11-16 1:36 ` [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 Krzysztof Kozlowski
2015-11-16 3:05 ` Chanwoo Choi
2015-11-17 4:31 ` pankaj.dubey
2015-11-17 4:39 ` Krzysztof Kozlowski
2015-11-17 14:01 ` Sylwester Nawrocki
2015-11-19 4:10 ` [1/2] " Alim Akhtar
2015-11-19 4:18 ` [PATCH 1/2] " Tomasz Figa
2015-11-19 4:51 ` Krzysztof Kozlowski
2015-11-19 9:16 ` Tomasz Figa
2015-11-19 9:41 ` Krzysztof Kozlowski
2015-11-19 11:05 ` Sylwester Nawrocki
2015-11-16 1:36 ` [PATCH 2/2] arm64: EXYNOS: Consolidate ARCH_EXYNOS7 symbol into ARCH_EXYNOS Krzysztof Kozlowski
2015-11-16 2:55 ` Chanwoo Choi
2015-11-17 4:25 ` pankaj.dubey
2015-11-19 4:04 ` [2/2] " Alim Akhtar
2015-11-19 4:23 ` [PATCH 2/2] " Tomasz Figa
2015-11-19 4:36 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564D51DB.1040904@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).