From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7
Date: Thu, 19 Nov 2015 12:05:46 +0100 [thread overview]
Message-ID: <564DAD0A.3000007@samsung.com> (raw)
In-Reply-To: <CA+Ln22GTPFk6KpWZPDzLRBqO8B+iwwesQEzBwYikXnf0gr3Csg@mail.gmail.com>
On 19/11/15 10:16, Tomasz Figa wrote:
> 2015-11-19 13:51 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>:
>> > On 19.11.2015 13:18, Tomasz Figa wrote:
>>> >> However, I don't think we can disable compilation of particular
>>> >> 64-bit SoCs, so maybe there isn't much sense in splitting their
>>> >> clock drivers into separate symbols?
>> >
>> > To me it does not really matter. Indeed as you said one cannot
>> > disable building of one particular Exynos SoCs.
>> >
>> > However we could still want not build some parts of such SoCs (like
>> > clock, pinctrl etc). I don't see much benefit for such case except
>> > when someone would like to drastically reduce the size of kernel
>> > image (for whatever reasons he has.).
>
> Can we really build a kernel that support selected Exynos SoC without
> its clock driver? Actually I don't think we even allow deselecting
> clock drivers currently, because they are not visible in menuconfig.
> Unless there is a clear goal to separate ARCH level Kconfig symbol for
> particular ARM64-based Exynos SoCs, I don't think it makes any sense
> to keep the clock-related symbols separate.
>
>> >
>> > On the other hand having separate symbols causes duplication and
>> > obfuscates a little the Kconfig/Makefile. I like keeping things
>> > simple so one symbol for all ARM64 Exynos clocks sounds good.
>> >
>> > Sylwester preferred current approach. You and Pankaj seem to prefer
>> > one symbol-way.
>
> Hmm, I read Sylwester's post as a reply to your original message and
> not Pankaj's. Sylwester, could you clarify?
OK, let's just use a common clk Kconfig symbol for Exynos ARM64.
What I tried to say is that with addition of support for few more
of those SoCs the kernel image size can easily grow by 1MB order,
due to just clk drivers inclusion. Perhaps it's not a big issue
with current hardware configuration.
Maybe in long term we should think about splitting CMU drivers
into a built-in critical clocks part and the rest in loadable
modules.
--
Thanks,
Sylwester
next prev parent reply other threads:[~2015-11-19 11:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 1:36 [PATCH 0/2] arm64: EXYNOS: Consolidate Exynos7 symbol Krzysztof Kozlowski
2015-11-16 1:36 ` [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 Krzysztof Kozlowski
2015-11-16 3:05 ` Chanwoo Choi
2015-11-17 4:31 ` pankaj.dubey
2015-11-17 4:39 ` Krzysztof Kozlowski
2015-11-17 14:01 ` Sylwester Nawrocki
2015-11-19 4:10 ` [1/2] " Alim Akhtar
2015-11-19 4:18 ` [PATCH 1/2] " Tomasz Figa
2015-11-19 4:51 ` Krzysztof Kozlowski
2015-11-19 9:16 ` Tomasz Figa
2015-11-19 9:41 ` Krzysztof Kozlowski
2015-11-19 11:05 ` Sylwester Nawrocki [this message]
2015-11-16 1:36 ` [PATCH 2/2] arm64: EXYNOS: Consolidate ARCH_EXYNOS7 symbol into ARCH_EXYNOS Krzysztof Kozlowski
2015-11-16 2:55 ` Chanwoo Choi
2015-11-17 4:25 ` pankaj.dubey
2015-11-19 4:04 ` [2/2] " Alim Akhtar
2015-11-19 4:23 ` [PATCH 2/2] " Tomasz Figa
2015-11-19 4:36 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564DAD0A.3000007@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).