* [PATCH] ARM: shmobile: alt: Add pfc pins to DT
@ 2015-11-17 19:10 Simon Horman
2015-11-18 13:04 ` Ulrich Hecht
2015-11-20 12:11 ` Sergei Shtylyov
0 siblings, 2 replies; 7+ messages in thread
From: Simon Horman @ 2015-11-17 19:10 UTC (permalink / raw)
To: linux-arm-kernel
PFC is already enabled on the r8a7794.
This adds pins for devices already enabled in DT on
the r8a7794 based alt board.
Based on work by Mitsuhiro Kimura and Hisashi Nakamura.
Cc: Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com>
Cc: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
Tested
---
arch/arm/boot/dts/r8a7794-alt.dts | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts
index 928cfa641475..2e889991ce8f 100644
--- a/arch/arm/boot/dts/r8a7794-alt.dts
+++ b/arch/arm/boot/dts/r8a7794-alt.dts
@@ -39,6 +39,23 @@
clock-frequency = <20000000>;
};
+&pfc {
+ scif2_pins: serial2 {
+ renesas,groups = "scif2_data";
+ renesas,function = "scif2";
+ };
+
+ ether_pins: ether {
+ renesas,groups = "eth_link", "eth_mdio", "eth_rmii";
+ renesas,function = "eth";
+ };
+
+ ether_b_pins: ether {
+ renesas,groups = "eth_link_b", "eth_mdio_b", "eth_rmii_b";
+ renesas,function = "eth";
+ };
+};
+
&cmt0 {
status = "okay";
};
--
2.1.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] ARM: shmobile: alt: Add pfc pins to DT
2015-11-17 19:10 [PATCH] ARM: shmobile: alt: Add pfc pins to DT Simon Horman
@ 2015-11-18 13:04 ` Ulrich Hecht
2015-11-18 20:52 ` Simon Horman
2015-11-20 12:11 ` Sergei Shtylyov
1 sibling, 1 reply; 7+ messages in thread
From: Ulrich Hecht @ 2015-11-18 13:04 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Nov 17, 2015 at 8:10 PM, Simon Horman
<horms+renesas@verge.net.au> wrote:
> PFC is already enabled on the r8a7794.
> This adds pins for devices already enabled in DT on
> the r8a7794 based alt board.
>
> Based on work by Mitsuhiro Kimura and Hisashi Nakamura.
>
> Cc: Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com>
> Cc: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Looks good.
Acked-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
CU
Uli
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: shmobile: alt: Add pfc pins to DT
2015-11-18 13:04 ` Ulrich Hecht
@ 2015-11-18 20:52 ` Simon Horman
0 siblings, 0 replies; 7+ messages in thread
From: Simon Horman @ 2015-11-18 20:52 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 18, 2015 at 02:04:33PM +0100, Ulrich Hecht wrote:
> On Tue, Nov 17, 2015 at 8:10 PM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > PFC is already enabled on the r8a7794.
> > This adds pins for devices already enabled in DT on
> > the r8a7794 based alt board.
> >
> > Based on work by Mitsuhiro Kimura and Hisashi Nakamura.
> >
> > Cc: Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com>
> > Cc: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
> Looks good.
>
> Acked-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Thanks for reviewing this.
I have queued it up.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: shmobile: alt: Add pfc pins to DT
2015-11-17 19:10 [PATCH] ARM: shmobile: alt: Add pfc pins to DT Simon Horman
2015-11-18 13:04 ` Ulrich Hecht
@ 2015-11-20 12:11 ` Sergei Shtylyov
2015-11-20 18:34 ` Simon Horman
1 sibling, 1 reply; 7+ messages in thread
From: Sergei Shtylyov @ 2015-11-20 12:11 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 11/17/2015 10:10 PM, Simon Horman wrote:
> PFC is already enabled on the r8a7794.
> This adds pins for devices already enabled in DT on
> the r8a7794 based alt board.
>
> Based on work by Mitsuhiro Kimura and Hisashi Nakamura.
>
> Cc: Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com>
> Cc: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
> ---
> Tested
> ---
> arch/arm/boot/dts/r8a7794-alt.dts | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts
> index 928cfa641475..2e889991ce8f 100644
> --- a/arch/arm/boot/dts/r8a7794-alt.dts
> +++ b/arch/arm/boot/dts/r8a7794-alt.dts
> @@ -39,6 +39,23 @@
> clock-frequency = <20000000>;
> };
>
> +&pfc {
> + scif2_pins: serial2 {
> + renesas,groups = "scif2_data";
> + renesas,function = "scif2";
> + };
> +
> + ether_pins: ether {
> + renesas,groups = "eth_link", "eth_mdio", "eth_rmii";
> + renesas,function = "eth";
> + };
> +
> + ether_b_pins: ether {
> + renesas,groups = "eth_link_b", "eth_mdio_b", "eth_rmii_b";
> + renesas,function = "eth";
> + };
> +};
> +
> &cmt0 {
> status = "okay";
> };
Why add unreferenced pins? How have you tested this?
MBR, Sergei
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] ARM: shmobile: alt: Add pfc pins to DT
2015-11-20 12:11 ` Sergei Shtylyov
@ 2015-11-20 18:34 ` Simon Horman
2015-11-20 18:50 ` Sergei Shtylyov
0 siblings, 1 reply; 7+ messages in thread
From: Simon Horman @ 2015-11-20 18:34 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Nov 20, 2015 at 03:11:17PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 11/17/2015 10:10 PM, Simon Horman wrote:
>
> >PFC is already enabled on the r8a7794.
> >This adds pins for devices already enabled in DT on
> >the r8a7794 based alt board.
> >
> >Based on work by Mitsuhiro Kimura and Hisashi Nakamura.
> >
> >Cc: Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com>
> >Cc: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >
> >---
> >Tested
> >---
> > arch/arm/boot/dts/r8a7794-alt.dts | 17 +++++++++++++++++
> > 1 file changed, 17 insertions(+)
> >
> >diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts
> >index 928cfa641475..2e889991ce8f 100644
> >--- a/arch/arm/boot/dts/r8a7794-alt.dts
> >+++ b/arch/arm/boot/dts/r8a7794-alt.dts
> >@@ -39,6 +39,23 @@
> > clock-frequency = <20000000>;
> > };
> >
> >+&pfc {
> >+ scif2_pins: serial2 {
> >+ renesas,groups = "scif2_data";
> >+ renesas,function = "scif2";
> >+ };
> >+
> >+ ether_pins: ether {
> >+ renesas,groups = "eth_link", "eth_mdio", "eth_rmii";
> >+ renesas,function = "eth";
> >+ };
> >+
> >+ ether_b_pins: ether {
> >+ renesas,groups = "eth_link_b", "eth_mdio_b", "eth_rmii_b";
> >+ renesas,function = "eth";
> >+ };
> >+};
> >+
> > &cmt0 {
> > status = "okay";
> > };
>
> Why add unreferenced pins? How have you tested this?
Thanks for pointing out that oversight. I'll see about filling in the gaps.
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] ARM: shmobile: alt: Add pfc pins to DT
2015-11-20 18:34 ` Simon Horman
@ 2015-11-20 18:50 ` Sergei Shtylyov
2015-11-21 0:40 ` Simon Horman
0 siblings, 1 reply; 7+ messages in thread
From: Sergei Shtylyov @ 2015-11-20 18:50 UTC (permalink / raw)
To: linux-arm-kernel
On 11/20/2015 09:34 PM, Simon Horman wrote:
>>> PFC is already enabled on the r8a7794.
>>> This adds pins for devices already enabled in DT on
>>> the r8a7794 based alt board.
>>>
>>> Based on work by Mitsuhiro Kimura and Hisashi Nakamura.
>>>
>>> Cc: Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com>
>>> Cc: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>>>
>>> ---
>>> Tested
>>> ---
>>> arch/arm/boot/dts/r8a7794-alt.dts | 17 +++++++++++++++++
>>> 1 file changed, 17 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts
>>> index 928cfa641475..2e889991ce8f 100644
>>> --- a/arch/arm/boot/dts/r8a7794-alt.dts
>>> +++ b/arch/arm/boot/dts/r8a7794-alt.dts
>>> @@ -39,6 +39,23 @@
>>> clock-frequency = <20000000>;
>>> };
>>>
>>> +&pfc {
>>> + scif2_pins: serial2 {
>>> + renesas,groups = "scif2_data";
>>> + renesas,function = "scif2";
>>> + };
>>> +
>>> + ether_pins: ether {
>>> + renesas,groups = "eth_link", "eth_mdio", "eth_rmii";
>>> + renesas,function = "eth";
>>> + };
>>> +
>>> + ether_b_pins: ether {
>>> + renesas,groups = "eth_link_b", "eth_mdio_b", "eth_rmii_b";
>>> + renesas,function = "eth";
>>> + };
>>> +};
>>> +
>>> &cmt0 {
>>> status = "okay";
>>> };
>>
>> Why add unreferenced pins? How have you tested this?
>
> Thanks for pointing out that oversight. I'll see about filling in the gaps.
Sorry for noticing this too late, only when you were pushing your branches
upstream...
MBR, Sergei
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] ARM: shmobile: alt: Add pfc pins to DT
2015-11-20 18:50 ` Sergei Shtylyov
@ 2015-11-21 0:40 ` Simon Horman
0 siblings, 0 replies; 7+ messages in thread
From: Simon Horman @ 2015-11-21 0:40 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Nov 20, 2015 at 09:50:08PM +0300, Sergei Shtylyov wrote:
> On 11/20/2015 09:34 PM, Simon Horman wrote:
>
> >>>PFC is already enabled on the r8a7794.
> >>>This adds pins for devices already enabled in DT on
> >>>the r8a7794 based alt board.
> >>>
> >>>Based on work by Mitsuhiro Kimura and Hisashi Nakamura.
> >>>
> >>>Cc: Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com>
> >>>Cc: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> >>>Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >>>
> >>>---
> >>>Tested
> >>>---
> >>> arch/arm/boot/dts/r8a7794-alt.dts | 17 +++++++++++++++++
> >>> 1 file changed, 17 insertions(+)
> >>>
> >>>diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts
> >>>index 928cfa641475..2e889991ce8f 100644
> >>>--- a/arch/arm/boot/dts/r8a7794-alt.dts
> >>>+++ b/arch/arm/boot/dts/r8a7794-alt.dts
> >>>@@ -39,6 +39,23 @@
> >>> clock-frequency = <20000000>;
> >>> };
> >>>
> >>>+&pfc {
> >>>+ scif2_pins: serial2 {
> >>>+ renesas,groups = "scif2_data";
> >>>+ renesas,function = "scif2";
> >>>+ };
> >>>+
> >>>+ ether_pins: ether {
> >>>+ renesas,groups = "eth_link", "eth_mdio", "eth_rmii";
> >>>+ renesas,function = "eth";
> >>>+ };
> >>>+
> >>>+ ether_b_pins: ether {
> >>>+ renesas,groups = "eth_link_b", "eth_mdio_b", "eth_rmii_b";
> >>>+ renesas,function = "eth";
> >>>+ };
> >>>+};
> >>>+
> >>> &cmt0 {
> >>> status = "okay";
> >>> };
> >>
> >> Why add unreferenced pins? How have you tested this?
> >
> >Thanks for pointing out that oversight. I'll see about filling in the gaps.
>
> Sorry for noticing this too late, only when you were pushing your
> branches upstream...
No problem, thanks for noticing at all.
FYI:
It looks like things work well when using the scif2
but not the ether pins. I suspect the latter is due to the lack
of phy pin support both above and by inspection in the pfc driver.
I will investigate further.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-11-21 0:40 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-17 19:10 [PATCH] ARM: shmobile: alt: Add pfc pins to DT Simon Horman
2015-11-18 13:04 ` Ulrich Hecht
2015-11-18 20:52 ` Simon Horman
2015-11-20 12:11 ` Sergei Shtylyov
2015-11-20 18:34 ` Simon Horman
2015-11-20 18:50 ` Sergei Shtylyov
2015-11-21 0:40 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).