From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: shmobile: alt: Add pfc pins to DT
Date: Fri, 20 Nov 2015 21:50:08 +0300 [thread overview]
Message-ID: <564F6B60.60405@cogentembedded.com> (raw)
In-Reply-To: <20151120183451.GD29534@verge.net.au>
On 11/20/2015 09:34 PM, Simon Horman wrote:
>>> PFC is already enabled on the r8a7794.
>>> This adds pins for devices already enabled in DT on
>>> the r8a7794 based alt board.
>>>
>>> Based on work by Mitsuhiro Kimura and Hisashi Nakamura.
>>>
>>> Cc: Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com>
>>> Cc: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>>>
>>> ---
>>> Tested
>>> ---
>>> arch/arm/boot/dts/r8a7794-alt.dts | 17 +++++++++++++++++
>>> 1 file changed, 17 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts
>>> index 928cfa641475..2e889991ce8f 100644
>>> --- a/arch/arm/boot/dts/r8a7794-alt.dts
>>> +++ b/arch/arm/boot/dts/r8a7794-alt.dts
>>> @@ -39,6 +39,23 @@
>>> clock-frequency = <20000000>;
>>> };
>>>
>>> +&pfc {
>>> + scif2_pins: serial2 {
>>> + renesas,groups = "scif2_data";
>>> + renesas,function = "scif2";
>>> + };
>>> +
>>> + ether_pins: ether {
>>> + renesas,groups = "eth_link", "eth_mdio", "eth_rmii";
>>> + renesas,function = "eth";
>>> + };
>>> +
>>> + ether_b_pins: ether {
>>> + renesas,groups = "eth_link_b", "eth_mdio_b", "eth_rmii_b";
>>> + renesas,function = "eth";
>>> + };
>>> +};
>>> +
>>> &cmt0 {
>>> status = "okay";
>>> };
>>
>> Why add unreferenced pins? How have you tested this?
>
> Thanks for pointing out that oversight. I'll see about filling in the gaps.
Sorry for noticing this too late, only when you were pushing your branches
upstream...
MBR, Sergei
next prev parent reply other threads:[~2015-11-20 18:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 19:10 [PATCH] ARM: shmobile: alt: Add pfc pins to DT Simon Horman
2015-11-18 13:04 ` Ulrich Hecht
2015-11-18 20:52 ` Simon Horman
2015-11-20 12:11 ` Sergei Shtylyov
2015-11-20 18:34 ` Simon Horman
2015-11-20 18:50 ` Sergei Shtylyov [this message]
2015-11-21 0:40 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564F6B60.60405@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).