From: vz@mleia.com (Vladimir Zapolskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 8/8] arm: dts: lpc32xx: move USB controller subdevices into own device node
Date: Fri, 20 Nov 2015 22:05:56 +0200 [thread overview]
Message-ID: <564F7D24.8040009@mleia.com> (raw)
In-Reply-To: <CAL_JsqJZ+fKe32gaKAJa+8KvaDkNJS0rWD+NQH7hkWxaahC4ag@mail.gmail.com>
On 20.11.2015 21:47, Rob Herring wrote:
> On Sat, Oct 17, 2015 at 4:35 PM, Vladimir Zapolskiy <vz@mleia.com> wrote:
>> NXP LPC32xx SoC has one USB OTG controller, which is supposed to work
>> with an external phy (default is NXP ISP1301).
>>
>> Practically the USB controller contains 5 subdevices:
>> - host controller 0x3102 0000 -- 0x3102 00FF
>> - OTG controller 0x3102 0100 -- 0x3102 01FF
>> - device controller 0x3102 0200 -- 0x3102 02FF
>> - I2C controller 0x3102 0300 -- 0x3102 03FF
>> - clock controller 0x3102 0F00 -- 0x3102 0FFF
>
> [...]
>
>> - /*
>> - * Enable either ohci or usbd (gadget)!
>> - */
>> - ohci: ohci at 31020000 {
>> - compatible = "nxp,ohci-nxp", "usb-ohci";
>> - reg = <0x31020000 0x300>;
>> - interrupts = <0x3b 0>;
>> - status = "disabled";
>> - };
>> + usb {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "simple-bus";
>> + ranges = <0x0 0x31020000 0x00001000>;
>>
>> - usbd: usbd at 31020000 {
>> - compatible = "nxp,lpc3220-udc";
>> - reg = <0x31020000 0x300>;
>> - interrupts = <0x3d 0>, <0x3e 0>, <0x3c 0>, <0x3a 0>;
>> - status = "disabled";
>> + /*
>> + * Enable either ohci or usbd (gadget)!
>> + */
>> + ohci: ohci at 0 {
>> + compatible = "nxp,ohci-nxp", "usb-ohci";
>> + reg = <0x0 0x300>;
>> + interrupts = <0x3b 0>;
>> + status = "disabled";
>> + };
>> +
>> + usbd: usbd at 0 {
>> + compatible = "nxp,lpc3220-udc";
>> + reg = <0x0 0x300>;
>
> Not a result of this change, but you are overlapping addresses. Please
> don't do that. It causes problems adding device resources into the
> resource tree (i.e. request_resource).
>
As you noticed this is legacy code, it will be corrected after fixing
USB host and device drivers, and this is in long term plans. USB changes
require at least CCF and IRQ chip changes applied.
--
With best wishes,
Vladimir
next prev parent reply other threads:[~2015-11-20 20:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-17 21:35 [PATCH v2 0/8] arm: dts: lpc32xx: updates to LPC32xx SoC and boards Vladimir Zapolskiy
2015-10-17 21:35 ` [PATCH v2 1/8] arm: dts: lpc32xx: change include syntax to be C preprocessor friendly Vladimir Zapolskiy
2015-10-17 21:35 ` [PATCH v2 2/8] arm: dts: lpc32xx: add labels to all defined peripheral nodes Vladimir Zapolskiy
2015-10-17 21:35 ` [PATCH v2 3/8] arm: dts: lpc32xx: add reg property to cpu device node Vladimir Zapolskiy
2015-10-17 21:35 ` [PATCH v2 4/8] arm: dts: lpc32xx: add device node for the second pwm controller Vladimir Zapolskiy
2015-10-17 21:35 ` [PATCH v2 5/8] arm: dts: ea3250/phy3250: specify phys memory offset for lpc32xx boards Vladimir Zapolskiy
2015-10-17 21:35 ` [PATCH v2 6/8] arm: dts: lpc32xx: add external memory controller device node Vladimir Zapolskiy
2015-10-17 21:35 ` [PATCH v2 7/8] arm: dts: lpc32xx: add device nodes for standard timers Vladimir Zapolskiy
2015-10-17 21:41 ` [PATCH v3 " Vladimir Zapolskiy
2015-10-17 21:35 ` [PATCH v2 8/8] arm: dts: lpc32xx: move USB controller subdevices into own device node Vladimir Zapolskiy
2015-11-20 19:47 ` Rob Herring
2015-11-20 20:05 ` Vladimir Zapolskiy [this message]
2015-10-21 14:45 ` [PATCH v2 0/8] arm: dts: lpc32xx: updates to LPC32xx SoC and boards Arnd Bergmann
2015-10-29 22:06 ` Vladimir Zapolskiy
2015-11-08 15:39 ` Vladimir Zapolskiy
2015-11-13 20:20 ` Vladimir Zapolskiy
2015-11-13 21:16 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564F7D24.8040009@mleia.com \
--to=vz@mleia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).