From: santosh.shilimkar@oracle.com (santosh shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] soc: ti: knav_qmss_queue: Fix linking RAM setup for queue managers
Date: Fri, 20 Nov 2015 15:47:38 -0800 [thread overview]
Message-ID: <564FB11A.3020906@oracle.com> (raw)
In-Reply-To: <1448062781-6708-1-git-send-email-michal.1.morawiec.ext@nokia.com>
On 11/20/2015 3:39 PM, Michal Morawiec wrote:
> Configure linking RAM for both queue managers also in case
> when only linking RAM 0 is specified in device tree.
>
why ?
> Signed-off-by: Michal Morawiec <michal.1.morawiec.ext@nokia.com>
> ---
> drivers/soc/ti/knav_qmss_queue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
> index 6d8646d..a809c30 100644
> --- a/drivers/soc/ti/knav_qmss_queue.c
> +++ b/drivers/soc/ti/knav_qmss_queue.c
> @@ -1173,7 +1173,7 @@ static int knav_queue_setup_link_ram(struct knav_device *kdev)
>
> block++;
> if (!block->size)
> - return 0;
> + continue;
>
You have to expand this a bit for me. Because you really don't
want kernel code to run the configuration on hardware which doesn't
exist. I mean device tree suppose to specify the linking RAM for both
QMs unless and until there is a reason not too.
Regards,
Santosh
next prev parent reply other threads:[~2015-11-20 23:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 23:39 [PATCH 1/1] soc: ti: knav_qmss_queue: Fix linking RAM setup for queue managers Michal Morawiec
2015-11-20 23:47 ` santosh shilimkar [this message]
2015-11-21 2:04 ` Michal Morawiec
2015-11-21 3:05 ` santosh.shilimkar at oracle.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564FB11A.3020906@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).