From: nyushchenko@dev.rtsoft.ru (Nikita Yushchenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC/PATCH] arm: do not skip SMP init calls on SMP_ON_UP case
Date: Mon, 23 Nov 2015 15:42:02 +0300 [thread overview]
Message-ID: <5653099A.7020604@dev.rtsoft.ru> (raw)
In-Reply-To: <56530769.4030403@arm.com>
>>>> While running an imx6s boasrd, I got following message in boot log:
>>>>
>>>> [ 0.032414] CPU1: failed to boot: -38
>>>>
>>>> This looked strange: imx6s is singe-core and kernel perfectly knows
>>>> that. However, for some reason it tries to initialize CPU 1?
>>>>
>>>> I found this to be caused by
>>>> - CONFIG_SMP_ON_UP successfully detects that system is single core,
>>>> - this causes is_smp() to return false,
>>>> - this causes setup_arch() to skip smp_init_cpus() call,
>>>> - this skips board-specific code that sets cpu_possible mask.
>>>
>>> Right, so you should end up with the possible and present masks
>>> containing just one CPU, which should prevent the kernel trying to
>>> bring any secondary CPUs online.
>>
>> Kernel that is running here still tries to init CPU 1 for some reason.
>
> I *guess* cpus node [1] in your dts has more than one cpu entry, could
> you check please?
Indeed looks so:
# ls /proc/device-tree/cpus
#address-cells #size-cells cpu at 0 cpu at 1 name
But my custom device tree just includes imx6dl.dtsi
So it is imx6dl.dtsi in linux-imx tree broken?..
Still, if I apply change from the patch, issue diappears, since in this
case imx_smp_init_cpus() gets called and initializes possible_cpu mask
properly.
next prev parent reply other threads:[~2015-11-23 12:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 11:59 [RFC/PATCH] arm: do not skip SMP init calls on SMP_ON_UP case nyushchenko at dev.rtsoft.ru
2015-11-23 12:03 ` Russell King - ARM Linux
2015-11-23 12:06 ` Nikita Yushchenko
2015-11-23 12:12 ` Russell King - ARM Linux
2015-11-23 12:19 ` Russell King - ARM Linux
2015-11-23 12:46 ` Nikita Yushchenko
2015-11-23 12:32 ` Vladimir Murzin
2015-11-23 12:42 ` Nikita Yushchenko [this message]
2015-11-23 12:47 ` Nikita Yushchenko
2015-11-23 13:04 ` Russell King - ARM Linux
2015-11-24 14:52 ` Nikita Yushchenko
2015-11-24 15:05 ` Nikita Yushchenko
2015-11-24 15:28 ` Nikita Yushchenko
2015-11-24 15:33 ` Russell King - ARM Linux
2015-11-28 11:13 ` Nikita Yushchenko
2015-11-30 8:25 ` Nikita Yushchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5653099A.7020604@dev.rtsoft.ru \
--to=nyushchenko@dev.rtsoft.ru \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).