From mboxrd@z Thu Jan 1 00:00:00 1970 From: lars@metafoo.de (Lars-Peter Clausen) Date: Tue, 24 Nov 2015 08:44:38 +0100 Subject: [LINUX PATCH] iio: xadc: fix for extended name remains same issue In-Reply-To: <1448345847-15051-1-git-send-email-ranjit.waghmode@xilinx.com> References: <1448345847-15051-1-git-send-email-ranjit.waghmode@xilinx.com> Message-ID: <56541566.80604@metafoo.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/24/2015 07:17 AM, Ranjit Waghmode wrote: > If we read channel details based on the device tree entry; channel?s scan_index > and channel?s address were overwritten by scan_index and address of channel > based on device tree. But extended name were remaining same because of which > sysfs entry names were continuous. I don't understand this part. Those channels don't have a extended name, they are always NULL. Those are added as part of this patch as well, but the patch description makes it sound like it is a fix for a existing issue. > > So this patch takes care of the above issue by updating 'channels' structure > inside xadc_parse_dt() function with the help of 'xadc_channels' structure > so that every channel's parameters will be updated properly. Also for the > sake of simplicity this patch updates default values for extend_name. We can't really do that, that would break existing applications. And to be honest I don't think regular channels should have a extended name.