* PCIe regression with DRA7xx in 4.4-rc1
@ 2015-11-24 12:01 Kishon Vijay Abraham I
2015-11-24 12:08 ` Gabriele Paoloni
2015-11-24 12:14 ` Jisheng Zhang
0 siblings, 2 replies; 5+ messages in thread
From: Kishon Vijay Abraham I @ 2015-11-24 12:01 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI:
designware: Make driver arch-agnostic").
Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that I
observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O
error, err_mask=0x4)"
Logs using a Ethenet PCIe card [2]. Again here the PCIe card enumerates fine
but when I give ifconfig up, it fails.
If I just revert commit <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>, the PCIe
cards starts to work fine again
Logs using a SATA PCIe card [3]. Here the KINGSTON SSD gets detected fine.
Logs using a Ethernet PCIe card [4]. I'm able to do ping tests now.
Actually I'm not able to find any obvious problems with the patch and the irq
number and the memory resource also looks fine. Any idea what could be the problem?
[1] -> http://pastebin.ubuntu.com/13491456/
[2] -> http://pastebin.ubuntu.com/13491526/
[3] -> http://pastebin.ubuntu.com/13491658/
[4] -> http://pastebin.ubuntu.com/13491593/
Thanks
Kishon
^ permalink raw reply [flat|nested] 5+ messages in thread* PCIe regression with DRA7xx in 4.4-rc1
2015-11-24 12:01 PCIe regression with DRA7xx in 4.4-rc1 Kishon Vijay Abraham I
@ 2015-11-24 12:08 ` Gabriele Paoloni
2015-11-24 12:18 ` Kishon Vijay Abraham I
2015-11-24 12:14 ` Jisheng Zhang
1 sibling, 1 reply; 5+ messages in thread
From: Gabriele Paoloni @ 2015-11-24 12:08 UTC (permalink / raw)
To: linux-arm-kernel
Hi Kishon
> -----Original Message-----
> From: Kishon Vijay Abraham I [mailto:kishon at ti.com]
> Sent: 24 November 2015 12:01
> To: linux-pci at vger.kernel.org; linux-kernel at vger.kernel.org; linux-
> omap at vger.kernel.org; james.morse at arm.com; gabriel.fernandez at st.com;
> Minghuan.Lian at freescale.com; Wangzhou (B); Gabriele Paoloni; arnd at arndb.de;
> bhelgaas at google.com; pratyush.anand at gmail.com; Nori, Sekhar;
> jingoohan1 at gmail.com; linux-arm-kernel at lists.infradead.org
> Subject: PCIe regression with DRA7xx in 4.4-rc1
>
> Hi,
>
> I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI:
> designware: Make driver arch-agnostic").
>
> Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that
> I
> observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O
> error, err_mask=0x4)"
>
May this be related to the bug flagged in:
[PATCH] PCI: designware: remove wrong io_base assignment
[...]
diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
index 540f077c37ea..02a7452bdf23 100644
--- a/drivers/pci/host/pcie-designware.c
+++ b/drivers/pci/host/pcie-designware.c
@@ -440,7 +440,6 @@ int dw_pcie_host_init(struct pcie_port *pp)
ret, pp->io);
continue;
}
- pp->io_base = pp->io->start;
break;
case IORESOURCE_MEM:
pp->mem = win->res;
--
1.7.9.5
[...]
Can you try to see if applying the patch above solves the issue?
Thanks
Gab
> Logs using a Ethenet PCIe card [2]. Again here the PCIe card enumerates fine
> but when I give ifconfig up, it fails.
>
> If I just revert commit <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>, the PCIe
> cards starts to work fine again
>
> Logs using a SATA PCIe card [3]. Here the KINGSTON SSD gets detected fine.
> Logs using a Ethernet PCIe card [4]. I'm able to do ping tests now.
>
> Actually I'm not able to find any obvious problems with the patch and the irq
> number and the memory resource also looks fine. Any idea what could be the
> problem?
>
> [1] -> http://pastebin.ubuntu.com/13491456/
> [2] -> http://pastebin.ubuntu.com/13491526/
>
> [3] -> http://pastebin.ubuntu.com/13491658/
> [4] -> http://pastebin.ubuntu.com/13491593/
>
> Thanks
> Kishon
^ permalink raw reply related [flat|nested] 5+ messages in thread* PCIe regression with DRA7xx in 4.4-rc1
2015-11-24 12:08 ` Gabriele Paoloni
@ 2015-11-24 12:18 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 5+ messages in thread
From: Kishon Vijay Abraham I @ 2015-11-24 12:18 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Tuesday 24 November 2015 05:38 PM, Gabriele Paoloni wrote:
> Hi Kishon
>
>> -----Original Message-----
>> From: Kishon Vijay Abraham I [mailto:kishon at ti.com]
>> Sent: 24 November 2015 12:01
>> To: linux-pci at vger.kernel.org; linux-kernel at vger.kernel.org; linux-
>> omap at vger.kernel.org; james.morse at arm.com; gabriel.fernandez at st.com;
>> Minghuan.Lian at freescale.com; Wangzhou (B); Gabriele Paoloni; arnd at arndb.de;
>> bhelgaas at google.com; pratyush.anand at gmail.com; Nori, Sekhar;
>> jingoohan1 at gmail.com; linux-arm-kernel at lists.infradead.org
>> Subject: PCIe regression with DRA7xx in 4.4-rc1
>>
>> Hi,
>>
>> I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI:
>> designware: Make driver arch-agnostic").
>>
>> Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that
>> I
>> observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O
>> error, err_mask=0x4)"
>>
>
> May this be related to the bug flagged in:
>
> [PATCH] PCI: designware: remove wrong io_base assignment
>
> [...]
> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
> index 540f077c37ea..02a7452bdf23 100644
> --- a/drivers/pci/host/pcie-designware.c
> +++ b/drivers/pci/host/pcie-designware.c
> @@ -440,7 +440,6 @@ int dw_pcie_host_init(struct pcie_port *pp)
> ret, pp->io);
> continue;
> }
> - pp->io_base = pp->io->start;
> break;
> case IORESOURCE_MEM:
> pp->mem = win->res;
>
yes, this indeed solved the bug.
Thanks
Kishon
^ permalink raw reply [flat|nested] 5+ messages in thread
* PCIe regression with DRA7xx in 4.4-rc1
2015-11-24 12:01 PCIe regression with DRA7xx in 4.4-rc1 Kishon Vijay Abraham I
2015-11-24 12:08 ` Gabriele Paoloni
@ 2015-11-24 12:14 ` Jisheng Zhang
2015-11-24 12:59 ` Kishon Vijay Abraham I
1 sibling, 1 reply; 5+ messages in thread
From: Jisheng Zhang @ 2015-11-24 12:14 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 24 Nov 2015 17:31:07 +0530
Kishon Vijay Abraham I wrote:
> Hi,
>
> I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI:
> designware: Make driver arch-agnostic").
>
> Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that I
> observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O
> error, err_mask=0x4)"
>
> Logs using a Ethenet PCIe card [2]. Again here the PCIe card enumerates fine
> but when I give ifconfig up, it fails.
>
> If I just revert commit <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>, the PCIe
> cards starts to work fine again
FYI, maybe the patch can fix the regression.
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-November/387362.html
>
> Logs using a SATA PCIe card [3]. Here the KINGSTON SSD gets detected fine.
> Logs using a Ethernet PCIe card [4]. I'm able to do ping tests now.
>
> Actually I'm not able to find any obvious problems with the patch and the irq
> number and the memory resource also looks fine. Any idea what could be the problem?
>
> [1] -> http://pastebin.ubuntu.com/13491456/
> [2] -> http://pastebin.ubuntu.com/13491526/
>
> [3] -> http://pastebin.ubuntu.com/13491658/
> [4] -> http://pastebin.ubuntu.com/13491593/
>
> Thanks
> Kishon
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* PCIe regression with DRA7xx in 4.4-rc1
2015-11-24 12:14 ` Jisheng Zhang
@ 2015-11-24 12:59 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 5+ messages in thread
From: Kishon Vijay Abraham I @ 2015-11-24 12:59 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Tuesday 24 November 2015 05:44 PM, Jisheng Zhang wrote:
>
>
> On Tue, 24 Nov 2015 17:31:07 +0530
> Kishon Vijay Abraham I wrote:
>
>> Hi,
>>
>> I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI:
>> designware: Make driver arch-agnostic").
>>
>> Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that I
>> observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O
>> error, err_mask=0x4)"
>>
>> Logs using a Ethenet PCIe card [2]. Again here the PCIe card enumerates fine
>> but when I give ifconfig up, it fails.
>>
>> If I just revert commit <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>, the PCIe
>> cards starts to work fine again
>
> FYI, maybe the patch can fix the regression.
> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-November/387362.html
yes, it fixed.
Thanks
Kishon
>
>>
>> Logs using a SATA PCIe card [3]. Here the KINGSTON SSD gets detected fine.
>> Logs using a Ethernet PCIe card [4]. I'm able to do ping tests now.
>>
>> Actually I'm not able to find any obvious problems with the patch and the irq
>> number and the memory resource also looks fine. Any idea what could be the problem?
>>
>> [1] -> http://pastebin.ubuntu.com/13491456/
>> [2] -> http://pastebin.ubuntu.com/13491526/
>>
>> [3] -> http://pastebin.ubuntu.com/13491658/
>> [4] -> http://pastebin.ubuntu.com/13491593/
>>
>> Thanks
>> Kishon
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-11-24 12:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-24 12:01 PCIe regression with DRA7xx in 4.4-rc1 Kishon Vijay Abraham I
2015-11-24 12:08 ` Gabriele Paoloni
2015-11-24 12:18 ` Kishon Vijay Abraham I
2015-11-24 12:14 ` Jisheng Zhang
2015-11-24 12:59 ` Kishon Vijay Abraham I
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).