From: sagig@dev.mellanox.co.il (Sagi Grimberg)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] scsi: use sector_div instead of do_div
Date: Tue, 24 Nov 2015 14:50:36 +0200 [thread overview]
Message-ID: <56545D1C.6070509@dev.mellanox.co.il> (raw)
In-Reply-To: <24882658.08y4bWL6tn@wuerfel>
On 20/11/2015 18:38, Arnd Bergmann wrote:
> do_div is the wrong way to divide a sector_t, as it is less
> efficient when sector_t is 32-bit wide. With the upcoming
> do_div optimizations, the kernel starts warning about this:
>
> drivers/scsi/scsi_debug.c: In function 'dif_store':
> include/asm-generic/div64.h:207:28: warning: comparison of distinct pointer types lacks a cast
>
> This changes the code to use sector_div instead, which always
> produces optimal code.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
next prev parent reply other threads:[~2015-11-24 12:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 16:38 [PATCH] scsi: use sector_div instead of do_div Arnd Bergmann
2015-11-24 12:48 ` Johannes Thumshirn
2015-11-24 12:50 ` Sagi Grimberg [this message]
2015-11-24 15:03 ` Hannes Reinecke
2015-11-26 3:28 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56545D1C.6070509@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).