From: alexander.sverdlin@gmail.com (Alexander Sverdlin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: ep93xx: Fix clocksource registration
Date: Wed, 25 Nov 2015 02:50:34 +0100 [thread overview]
Message-ID: <565513EA.6020603@gmail.com> (raw)
clocksource_mmio_init() explicitly checks for counter's width and refuses to
register anything with resolution higher than 32 bits. We need to use
clocksource_register_hz() directly to repair HIGH_RES_TIMERS.
=== Before ===
$ cat /sys/bus/clocksource/devices/clocksource0/available_clocksource
jiffies
$ cat /proc/timer_list
[...]
cpu: 0
clock 0:
.base: c0388ae0
.index: 0
.resolution: 10000000 nsecs
.get_time: ktime_get
.offset: 0 nsecs
active timers:
[...]
Tick Device: mode: 0
Per CPU device: 0
Clock Event Device: timer1
max_delta_ns: 8446860587738
min_delta_ns: 1967
mult: 1091929
shift: 31
mode: 3
next_event: 130610000000 nsecs
set_next_event: ep93xx_clkevt_set_next_event
shutdown: ep93xx_clkevt_shutdown
oneshot: ep93xx_clkevt_shutdown
resume: ep93xx_clkevt_shutdown
event_handler: tick_handle_periodic
retries: 0
=== After ===
$ cat /sys/bus/clocksource/devices/clocksource0/available_clocksource
timer4
$ cat /proc/timer_list
[...]
cpu: 0
clock 0:
.base: c0388b40
.index: 0
.resolution: 1 nsecs
.get_time: ktime_get
.offset: 0 nsecs
active timers:
[...]
Tick Device: mode: 1
Per CPU device: 0
Clock Event Device: timer1
max_delta_ns: 8446860587738
min_delta_ns: 1967
mult: 1091929
shift: 31
mode: 3
next_event: 101000000000 nsecs
set_next_event: ep93xx_clkevt_set_next_event
shutdown: ep93xx_clkevt_shutdown
oneshot: ep93xx_clkevt_shutdown
resume: ep93xx_clkevt_shutdown
event_handler: hrtimer_interrupt
retries: 1771
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
---
arch/arm/Kconfig | 1 -
arch/arm/mach-ep93xx/timer-ep93xx.c | 13 ++++++++++---
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 0365cbb..c655597 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -422,7 +422,6 @@ config ARCH_EP93XX
select ARM_VIC
select AUTO_ZRELADDR
select CLKDEV_LOOKUP
- select CLKSRC_MMIO
select CPU_ARM920T
select GENERIC_CLOCKEVENTS
help
diff --git a/arch/arm/mach-ep93xx/timer-ep93xx.c b/arch/arm/mach-ep93xx/timer-ep93xx.c
index e5f7911..893992b 100644
--- a/arch/arm/mach-ep93xx/timer-ep93xx.c
+++ b/arch/arm/mach-ep93xx/timer-ep93xx.c
@@ -68,6 +68,14 @@ cycle_t ep93xx_clocksource_read(struct clocksource *c)
return (cycle_t) ret;
}
+static struct clocksource timer4_clocksource = {
+ .name = "timer4",
+ .rating = 200,
+ .read = ep93xx_clocksource_read,
+ .mask = CLOCKSOURCE_MASK(40),
+ .flags = CLOCK_SOURCE_IS_CONTINUOUS,
+};
+
static int ep93xx_clkevt_set_next_event(unsigned long next,
struct clock_event_device *evt)
{
@@ -128,9 +136,8 @@ void __init ep93xx_timer_init(void)
/* Enable and register clocksource and sched_clock on timer 4 */
writel(EP93XX_TIMER4_VALUE_HIGH_ENABLE,
EP93XX_TIMER4_VALUE_HIGH);
- clocksource_mmio_init(NULL, "timer4",
- EP93XX_TIMER4_RATE, 200, 40,
- ep93xx_clocksource_read);
+ if (clocksource_register_hz(&timer4_clocksource, EP93XX_TIMER4_RATE))
+ pr_warn("Failed to register Timer4 as clocksource");
sched_clock_register(ep93xx_read_sched_clock, 40,
EP93XX_TIMER4_RATE);
next reply other threads:[~2015-11-25 1:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 1:50 Alexander Sverdlin [this message]
2015-12-01 10:09 ` [PATCH] ARM: ep93xx: Fix clocksource registration Linus Walleij
2015-12-01 10:14 ` Alexander Sverdlin
2015-12-10 17:23 ` Linus Walleij
2015-12-10 17:32 ` Russell King - ARM Linux
2015-12-14 13:37 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565513EA.6020603@gmail.com \
--to=alexander.sverdlin@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).