* [PATCH] ASoC: rockchip: Fix incorrect VDW value for 24 bit
@ 2015-11-25 8:54 Sjoerd Simons
2015-11-25 9:03 ` Caesar Wang
0 siblings, 1 reply; 2+ messages in thread
From: Sjoerd Simons @ 2015-11-25 8:54 UTC (permalink / raw)
To: linux-arm-kernel
Correct valid data word register value for 24 bit data width. The
bit value should be 10 (aka 0x2), not 0x10.
This fixes playback of 24 bit audio.
Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
---
sound/soc/rockchip/rockchip_spdif.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/rockchip/rockchip_spdif.h b/sound/soc/rockchip/rockchip_spdif.h
index 07f86a2..921b409 100644
--- a/sound/soc/rockchip/rockchip_spdif.h
+++ b/sound/soc/rockchip/rockchip_spdif.h
@@ -28,9 +28,9 @@
#define SPDIF_CFGR_VDW(x) (x << SPDIF_CFGR_VDW_SHIFT)
#define SDPIF_CFGR_VDW_MASK (0xf << SPDIF_CFGR_VDW_SHIFT)
-#define SPDIF_CFGR_VDW_16 SPDIF_CFGR_VDW(0x00)
-#define SPDIF_CFGR_VDW_20 SPDIF_CFGR_VDW(0x01)
-#define SPDIF_CFGR_VDW_24 SPDIF_CFGR_VDW(0x10)
+#define SPDIF_CFGR_VDW_16 SPDIF_CFGR_VDW(0x0)
+#define SPDIF_CFGR_VDW_20 SPDIF_CFGR_VDW(0x1)
+#define SPDIF_CFGR_VDW_24 SPDIF_CFGR_VDW(0x2)
/*
* DMACR
--
2.6.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ASoC: rockchip: Fix incorrect VDW value for 24 bit
2015-11-25 8:54 [PATCH] ASoC: rockchip: Fix incorrect VDW value for 24 bit Sjoerd Simons
@ 2015-11-25 9:03 ` Caesar Wang
0 siblings, 0 replies; 2+ messages in thread
From: Caesar Wang @ 2015-11-25 9:03 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
? 2015?11?25? 16:54, Sjoerd Simons ??:
> Correct valid data word register value for 24 bit data width. The
> bit value should be 10 (aka 0x2), not 0x10.
>
> This fixes playback of 24 bit audio.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
>
> ---
>
> sound/soc/rockchip/rockchip_spdif.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/rockchip/rockchip_spdif.h b/sound/soc/rockchip/rockchip_spdif.h
> index 07f86a2..921b409 100644
> --- a/sound/soc/rockchip/rockchip_spdif.h
> +++ b/sound/soc/rockchip/rockchip_spdif.h
> @@ -28,9 +28,9 @@
> #define SPDIF_CFGR_VDW(x) (x << SPDIF_CFGR_VDW_SHIFT)
> #define SDPIF_CFGR_VDW_MASK (0xf << SPDIF_CFGR_VDW_SHIFT)
>
> -#define SPDIF_CFGR_VDW_16 SPDIF_CFGR_VDW(0x00)
> -#define SPDIF_CFGR_VDW_20 SPDIF_CFGR_VDW(0x01)
> -#define SPDIF_CFGR_VDW_24 SPDIF_CFGR_VDW(0x10)
> +#define SPDIF_CFGR_VDW_16 SPDIF_CFGR_VDW(0x0)
> +#define SPDIF_CFGR_VDW_20 SPDIF_CFGR_VDW(0x1)
> +#define SPDIF_CFGR_VDW_24 SPDIF_CFGR_VDW(0x2)
Yep,
From the TRM says: (RK3288/RK3368...)
VDW
Valid data width
00: 16bit
01: 20bit
10: 24bit
11: reserved
....
So feel free add my tag:
Reviewed-by: Caesar Wang <wxt@rock-chips.com>
>
> /*
> * DMACR
--
caesar wang | software engineer | wxt at rock-chip.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-25 9:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-25 8:54 [PATCH] ASoC: rockchip: Fix incorrect VDW value for 24 bit Sjoerd Simons
2015-11-25 9:03 ` Caesar Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).