From: m.szyprowski@samsung.com (Marek Szyprowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] drivers: amba: properly handle devices with power domains
Date: Thu, 26 Nov 2015 13:33:35 +0100 [thread overview]
Message-ID: <5656FC1F.6060705@samsung.com> (raw)
In-Reply-To: <20151126105945.GZ8644@n2100.arm.linux.org.uk>
Hello,
On 2015-11-26 11:59, Russell King - ARM Linux wrote:
> On Thu, Nov 26, 2015 at 11:24:50AM +0100, Ulf Hansson wrote:
>> On 26 November 2015 at 09:39, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>>> Hello,
>>>
>>> On 2015-11-25 19:09, Russell King - ARM Linux wrote:
>>>> On Wed, Nov 25, 2015 at 02:56:10PM +0100, Ulf Hansson wrote:
>>>>> On 25 November 2015 at 14:34, Marek Szyprowski <m.szyprowski@samsung.com>
>>>>> wrote:
>>>>>> Is ignoring dev_pm_domain_attach() return value a solution for you?
>>>>> That's probably better than nothing, but I wonder if it in practice
>>>>> will have any effect?
>>>> If the PM domain is down, then trying to tread the ID is likely to oops
>>>> the kernel.
>>>
>>> In my case kernel simply hangs (no single message, even when earlyprintk is
>>> enabled)
>>> instead of oopsing, that's why I've submitted this patch.
>>>
>> Okay.
>>
>> I suggest we go ahead and try that approach (ignoring the return
>> value). It's "quick fix", but the easiest way forward to solve the
>> problem.
>>
>> My only concern is if such change impacts the boot time. We should do
>> some tests to see if the change is negligible, if not we should
>> probably think of something else (like keeping the PM domain powered
>> until late_init).
>>
>> Russell, what do you think?
> I thought someone had a patch to read the ID during the match callback?
Okay, I've reused that patch and it seems to solve mthisproblem. I will
send v2
in a few minutes.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2015-11-26 12:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 12:55 [PATCH 0/2] Exynos4210: fix power domain for MDMA1 device Marek Szyprowski
2015-11-25 12:55 ` [PATCH] ARM: dts: exynos4210: Add power domain to G2D device Marek Szyprowski
2015-11-25 23:55 ` Krzysztof Kozlowski
2015-11-26 7:35 ` Krzysztof Kozlowski
2015-11-25 12:55 ` [PATCH 2/2] ARM: dts: exynos4210: MDMA1 device belongs to LCD0 power domain Marek Szyprowski
2015-11-25 12:58 ` [PATCH 1/2] drivers: amba: properly handle devices with power domains Marek Szyprowski
2015-11-25 13:24 ` Russell King - ARM Linux
2015-11-25 13:34 ` Marek Szyprowski
2015-11-25 13:56 ` Ulf Hansson
2015-11-25 14:43 ` Marek Szyprowski
2015-11-25 18:09 ` Russell King - ARM Linux
2015-11-26 8:39 ` Marek Szyprowski
2015-11-26 10:24 ` Ulf Hansson
2015-11-26 10:59 ` Russell King - ARM Linux
2015-11-26 12:33 ` Marek Szyprowski [this message]
2015-11-26 12:55 ` Marek Szyprowski
2015-11-26 15:04 ` Mathieu Poirier
2015-11-27 7:42 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5656FC1F.6060705@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).