From: huawei.libin@huawei.com (libin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: ftrace: stop using kstop_machine to enable/disable tracing
Date: Mon, 30 Nov 2015 10:03:26 +0800 [thread overview]
Message-ID: <565BAE6E.9060309@huawei.com> (raw)
In-Reply-To: <20151128105819.3451ab3e@grimm.local.home>
on 2015/11/28 23:58, Steven Rostedt wrote:
> On Sat, 28 Nov 2015 15:50:09 +0800
> Li Bin <huawei.libin@huawei.com> wrote:
>
>> On arm64, kstop_machine which is hugely disruptive to a running
>> system is not needed to convert nops to ftrace calls or back,
>> because that modifed code is a single 32bit instructions which
>> is impossible to cross cache (or page) boundaries, and the used str
>> instruction is single-copy atomic.
> Is this really true? I thought that arm (and then perhaps arm64) has
> some 2 byte instructions. If that's the case it is very well possible
> that a 4 byte instruction can cross cache lines.
When system in aarch32 state, it will use A32 or T32 instrucion set, and
T32 (thumb) have 16-bit instructions. But arm64 that in aarch64 state only
using A64 instruction set, which is a clean and fixed length instruction
set that instuctions are always 32 bits wide. Right?
Thanks,
Li Bin
> -- Steve
>
>> Cc: <stable@vger.kernel.org> # 3.18+
>> Signed-off-by: Li Bin <huawei.libin@huawei.com>
>> ---
>> arch/arm64/kernel/ftrace.c | 5 +++++
>> 1 files changed, 5 insertions(+), 0 deletions(-)
> .
>
next prev parent reply other threads:[~2015-11-30 2:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 7:50 [PATCH] arm64: ftrace: stop using kstop_machine to enable/disable tracing Li Bin
2015-11-28 15:58 ` Steven Rostedt
2015-11-30 2:03 ` libin [this message]
2015-12-02 12:36 ` Will Deacon
2015-12-02 13:16 ` Will Deacon
2015-12-03 9:39 ` libin
2015-12-03 11:48 ` Will Deacon
2015-12-03 15:07 ` Steven Rostedt
2015-12-02 14:02 ` Steven Rostedt
2015-12-03 9:21 ` libin
2015-12-03 9:38 ` Will Deacon
2015-12-03 15:05 ` Steven Rostedt
2015-12-03 15:09 ` Will Deacon
2015-12-03 15:31 ` Steven Rostedt
2015-12-04 1:00 ` libin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565BAE6E.9060309@huawei.com \
--to=huawei.libin@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).