From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: at91: fix pinctrl driver selection
Date: Tue, 1 Dec 2015 11:51:27 +0100 [thread overview]
Message-ID: <565D7BAF.6070208@atmel.com> (raw)
In-Reply-To: <1448966680-30281-1-git-send-email-ludovic.desroches@atmel.com>
Le 01/12/2015 11:44, Ludovic Desroches a ?crit :
> Move the selection of the pinctrl driver to SoC family level since we
> have two pinctrl drivers. It is useless to select one which is not
> compatible with the SoC.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Yep, it's even better. I plan to send it to 4.4-fixes very soon.
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
>
> This patch is an improvement of this one (already acked by Linus and Nicolas):
> https://lkml.org/lkml/2015/9/16/522
>
> Without it, at91 pio4 driver is not compiled causing boot failure for SAMA5D2.
>
> arch/arm/mach-at91/Kconfig | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
> index 9267300..28656c2 100644
> --- a/arch/arm/mach-at91/Kconfig
> +++ b/arch/arm/mach-at91/Kconfig
> @@ -4,7 +4,6 @@ menuconfig ARCH_AT91
> select ARCH_REQUIRE_GPIOLIB
> select COMMON_CLK_AT91
> select PINCTRL
> - select PINCTRL_AT91
> select SOC_BUS
>
> if ARCH_AT91
> @@ -17,6 +16,7 @@ config SOC_SAMA5D2
> select HAVE_AT91_USB_CLK
> select HAVE_AT91_H32MX
> select HAVE_AT91_GENERATED_CLK
> + select PINCTRL_AT91PIO4
> help
> Select this if ou are using one of Atmel's SAMA5D2 family SoC.
>
> @@ -27,6 +27,7 @@ config SOC_SAMA5D3
> select HAVE_AT91_UTMI
> select HAVE_AT91_SMD
> select HAVE_AT91_USB_CLK
> + select PINCTRL_AT91
> help
> Select this if you are using one of Atmel's SAMA5D3 family SoC.
> This support covers SAMA5D31, SAMA5D33, SAMA5D34, SAMA5D35, SAMA5D36.
> @@ -40,6 +41,7 @@ config SOC_SAMA5D4
> select HAVE_AT91_SMD
> select HAVE_AT91_USB_CLK
> select HAVE_AT91_H32MX
> + select PINCTRL_AT91
> help
> Select this if you are using one of Atmel's SAMA5D4 family SoC.
>
> @@ -50,6 +52,7 @@ config SOC_AT91RM9200
> select CPU_ARM920T
> select HAVE_AT91_USB_CLK
> select MIGHT_HAVE_PCI
> + select PINCTRL_AT91
> select SOC_SAM_V4_V5
> select SRAM if PM
> help
> @@ -65,6 +68,7 @@ config SOC_AT91SAM9
> select HAVE_AT91_UTMI
> select HAVE_FB_ATMEL
> select MEMORY
> + select PINCTRL_AT91
> select SOC_SAM_V4_V5
> select SRAM if PM
> help
>
--
Nicolas Ferre
next prev parent reply other threads:[~2015-12-01 10:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 10:44 [PATCH] ARM: at91: fix pinctrl driver selection Ludovic Desroches
2015-12-01 10:51 ` Nicolas Ferre [this message]
2015-12-01 11:17 ` Alexandre Belloni
2015-12-10 17:25 ` Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2015-12-04 17:18 Alexandre Belloni
2015-12-04 17:33 ` Sudeep Holla
2015-12-04 17:53 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565D7BAF.6070208@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).