* [PATCH 3/3] ARM: dts: enable pinctrl for Broadcom NSP
@ 2015-11-20 17:58 Yendapally Reddy Dhananjaya Reddy
2015-11-25 0:08 ` Florian Fainelli
2015-12-01 23:17 ` Florian Fainelli
0 siblings, 2 replies; 6+ messages in thread
From: Yendapally Reddy Dhananjaya Reddy @ 2015-11-20 17:58 UTC (permalink / raw)
To: linux-arm-kernel
This enables the pinctrl support for Broadcom NSP SoC
Signed-off-by: Yendapally Reddy Dhananjaya Reddy <yrdreddy@broadcom.com>
---
arch/arm/boot/dts/bcm-nsp.dtsi | 7 +++++++
arch/arm/boot/dts/bcm958625k.dts | 9 +++++++++
2 files changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi
index b74438c..a16d743 100644
--- a/arch/arm/boot/dts/bcm-nsp.dtsi
+++ b/arch/arm/boot/dts/bcm-nsp.dtsi
@@ -226,5 +226,12 @@
interrupts = <GIC_SPI 89 IRQ_TYPE_NONE>;
clock-frequency = <100000>;
};
+
+ pinctrl: pinctrl at 3f1c0 {
+ compatible = "brcm,nsp-pinmux";
+ reg = <0x3f1c0 0x04>,
+ <0x30028 0x04>,
+ <0x3f408 0x04>;
+ };
};
};
diff --git a/arch/arm/boot/dts/bcm958625k.dts b/arch/arm/boot/dts/bcm958625k.dts
index b966955..e298450 100644
--- a/arch/arm/boot/dts/bcm958625k.dts
+++ b/arch/arm/boot/dts/bcm958625k.dts
@@ -105,3 +105,12 @@
};
};
};
+
+&pinctrl {
+ pinctrl-names = "default";
+ pinctrl-0 = <&nand_sel>;
+ nand_sel: nand_sel {
+ function = "nand";
+ groups = "nand_grp";
+ };
+};
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] ARM: dts: enable pinctrl for Broadcom NSP
2015-11-20 17:58 [PATCH 3/3] ARM: dts: enable pinctrl for Broadcom NSP Yendapally Reddy Dhananjaya Reddy
@ 2015-11-25 0:08 ` Florian Fainelli
2015-12-01 10:00 ` Linus Walleij
2015-12-01 23:17 ` Florian Fainelli
1 sibling, 1 reply; 6+ messages in thread
From: Florian Fainelli @ 2015-11-25 0:08 UTC (permalink / raw)
To: linux-arm-kernel
On 20/11/15 09:58, Yendapally Reddy Dhananjaya Reddy wrote:
> This enables the pinctrl support for Broadcom NSP SoC
>
> Signed-off-by: Yendapally Reddy Dhananjaya Reddy <yrdreddy@broadcom.com>
Looks like a sane pinctrl node here, unless there are objections, I
would like to go ahead and apply this for v4.5, thanks!
> ---
> arch/arm/boot/dts/bcm-nsp.dtsi | 7 +++++++
> arch/arm/boot/dts/bcm958625k.dts | 9 +++++++++
> 2 files changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi
> index b74438c..a16d743 100644
> --- a/arch/arm/boot/dts/bcm-nsp.dtsi
> +++ b/arch/arm/boot/dts/bcm-nsp.dtsi
> @@ -226,5 +226,12 @@
> interrupts = <GIC_SPI 89 IRQ_TYPE_NONE>;
> clock-frequency = <100000>;
> };
> +
> + pinctrl: pinctrl at 3f1c0 {
> + compatible = "brcm,nsp-pinmux";
> + reg = <0x3f1c0 0x04>,
> + <0x30028 0x04>,
> + <0x3f408 0x04>;
> + };
> };
> };
> diff --git a/arch/arm/boot/dts/bcm958625k.dts b/arch/arm/boot/dts/bcm958625k.dts
> index b966955..e298450 100644
> --- a/arch/arm/boot/dts/bcm958625k.dts
> +++ b/arch/arm/boot/dts/bcm958625k.dts
> @@ -105,3 +105,12 @@
> };
> };
> };
> +
> +&pinctrl {
> + pinctrl-names = "default";
> + pinctrl-0 = <&nand_sel>;
> + nand_sel: nand_sel {
> + function = "nand";
> + groups = "nand_grp";
> + };
> +};
>
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] ARM: dts: enable pinctrl for Broadcom NSP
2015-11-25 0:08 ` Florian Fainelli
@ 2015-12-01 10:00 ` Linus Walleij
2015-12-01 16:05 ` Scott Branden
0 siblings, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2015-12-01 10:00 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 25, 2015 at 1:08 AM, Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 20/11/15 09:58, Yendapally Reddy Dhananjaya Reddy wrote:
>> This enables the pinctrl support for Broadcom NSP SoC
>>
>> Signed-off-by: Yendapally Reddy Dhananjaya Reddy <yrdreddy@broadcom.com>
>
> Looks like a sane pinctrl node here, unless there are objections, I
> would like to go ahead and apply this for v4.5, thanks!
I'm waiting for an indication from the other BCM pinctrl
maintainers to tell whether this SoC is unique enough to deserve
its own driver.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] ARM: dts: enable pinctrl for Broadcom NSP
2015-12-01 10:00 ` Linus Walleij
@ 2015-12-01 16:05 ` Scott Branden
2015-12-01 16:24 ` Ray Jui
0 siblings, 1 reply; 6+ messages in thread
From: Scott Branden @ 2015-12-01 16:05 UTC (permalink / raw)
To: linux-arm-kernel
Hi Linus,
On 15-12-01 02:00 AM, Linus Walleij wrote:
> On Wed, Nov 25, 2015 at 1:08 AM, Florian Fainelli <f.fainelli@gmail.com> wrote:
>> On 20/11/15 09:58, Yendapally Reddy Dhananjaya Reddy wrote:
>>> This enables the pinctrl support for Broadcom NSP SoC
>>>
>>> Signed-off-by: Yendapally Reddy Dhananjaya Reddy <yrdreddy@broadcom.com>
>>
>> Looks like a sane pinctrl node here, unless there are objections, I
>> would like to go ahead and apply this for v4.5, thanks!
>
> I'm waiting for an indication from the other BCM pinctrl
> maintainers to tell whether this SoC is unique enough to deserve
> its own driver.
If Stephen Warren is the other maintainer you are talking about he does
not work at Broadcom. I don't think he is familiar with the variety of
pinctrl implementations present. But yes, the pinctrl implementations
have been rather unique in these Socs. As Ray indicated we're trying to
get the silicon designers to standardize more going forward so we don't
have to create unique drivers for these SoCs.
>
> Yours,
> Linus Walleij
>
Regards,
Scott
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] ARM: dts: enable pinctrl for Broadcom NSP
2015-12-01 16:05 ` Scott Branden
@ 2015-12-01 16:24 ` Ray Jui
0 siblings, 0 replies; 6+ messages in thread
From: Ray Jui @ 2015-12-01 16:24 UTC (permalink / raw)
To: linux-arm-kernel
On 12/1/2015 8:05 AM, Scott Branden wrote:
> Hi Linus,
>
> On 15-12-01 02:00 AM, Linus Walleij wrote:
>> On Wed, Nov 25, 2015 at 1:08 AM, Florian Fainelli
>> <f.fainelli@gmail.com> wrote:
>>> On 20/11/15 09:58, Yendapally Reddy Dhananjaya Reddy wrote:
>>>> This enables the pinctrl support for Broadcom NSP SoC
>>>>
>>>> Signed-off-by: Yendapally Reddy Dhananjaya Reddy
>>>> <yrdreddy@broadcom.com>
>>>
>>> Looks like a sane pinctrl node here, unless there are objections, I
>>> would like to go ahead and apply this for v4.5, thanks!
>>
>> I'm waiting for an indication from the other BCM pinctrl
>> maintainers to tell whether this SoC is unique enough to deserve
>> its own driver.
> If Stephen Warren is the other maintainer you are talking about he does
> not work at Broadcom. I don't think he is familiar with the variety of
> pinctrl implementations present. But yes, the pinctrl implementations
> have been rather unique in these Socs. As Ray indicated we're trying to
> get the silicon designers to standardize more going forward so we don't
> have to create unique drivers for these SoCs.
Yes. Hopefully NSP and NS2 will be the last iProc based SoCs that
require unique pinmux driver.
>>
>> Yours,
>> Linus Walleij
>>
>
> Regards,
> Scott
>
Thanks,
Ray
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] ARM: dts: enable pinctrl for Broadcom NSP
2015-11-20 17:58 [PATCH 3/3] ARM: dts: enable pinctrl for Broadcom NSP Yendapally Reddy Dhananjaya Reddy
2015-11-25 0:08 ` Florian Fainelli
@ 2015-12-01 23:17 ` Florian Fainelli
1 sibling, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2015-12-01 23:17 UTC (permalink / raw)
To: linux-arm-kernel
On 20/11/15 09:58, Yendapally Reddy Dhananjaya Reddy wrote:
> This enables the pinctrl support for Broadcom NSP SoC
>
> Signed-off-by: Yendapally Reddy Dhananjaya Reddy <yrdreddy@broadcom.com>
Applied to devicetree/next, thanks!
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-12-01 23:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-20 17:58 [PATCH 3/3] ARM: dts: enable pinctrl for Broadcom NSP Yendapally Reddy Dhananjaya Reddy
2015-11-25 0:08 ` Florian Fainelli
2015-12-01 10:00 ` Linus Walleij
2015-12-01 16:05 ` Scott Branden
2015-12-01 16:24 ` Ray Jui
2015-12-01 23:17 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).