From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 763ADC761A6 for ; Tue, 4 Apr 2023 16:55:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r1+SG8pKmrcqXb8OVxcN99jxH+34yuoWf/dD6MrfMC8=; b=gZE+7HC4Kv/fqz QdW6q+TzFXGoducmMg9fFW2/Mif/3oLriy0dbJMmLwEcp7UuUBQmSKDfBOo4/+AgtkZVrnAsjBycK WGweHZunUps0rTe+qZ4/3bC0qzT23ETedhaDsAqJcJa/EvHNJIesvSbb5bPHjbenXJAJbQhwoCfbI IAt+1WxC3lCPVzcZ8rac8Bs7wgW3qgR9H/M/zLZLH4zL0eFxpYlzAcZX0/FcNN+ldNmxVoKmw+MkN F3SDTsFT5Cu9avLJR7F1M9S6/fJfIkd+S/8KDlSeQRTvX+pgQgONPHZEE7nA8JAt0r2lrE2DVcRyt Y2R52/G8Jlewk8/5tUVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pjjvW-002Hhz-1t; Tue, 04 Apr 2023 16:54:34 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pjjvS-002Hdy-1H for linux-arm-kernel@lists.infradead.org; Tue, 04 Apr 2023 16:54:32 +0000 Received: by mail-ed1-x534.google.com with SMTP id i5so133470581eda.0 for ; Tue, 04 Apr 2023 09:54:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680627266; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uv4LtfQw5vCBHk7SGSRKaduotTpobct6ipFsuhK2Lng=; b=oxHLTRLjT4/SdrADiXdbzX7O/ZIOtfZ27WdrhB32gkydWP9TkXjxBCBxdX8lIEFY/V iS4fWJSNLRwm8niSSJ3bOMMG6USQeTAEDk6D3pgR5a699HOX5aMzluCecY1XTqxcen7K D3CizZBnue62J/BUMNixLSR0oXpb1OGRe75g2p7WRz3MrWPewrYhyVZ4unuRMX2j2yyi p8yZutg2VsZDKvzmGf28yrOf1Jv2oqMaUej9u3hcd1h3J0QJRiDwIebkn2pkENDX9iT/ 9Rcqw1GLqJmFMgfUtvD2kueeI8PBxQjSEHUBNuIvQYxVX0XXbAnGtO/6pJ1/K00zhNyB S0vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680627266; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uv4LtfQw5vCBHk7SGSRKaduotTpobct6ipFsuhK2Lng=; b=6dzhD9/j93yD23ci1YrU5/GrTJVmak4u/nvns2vLEfN1fddJmTIZEh/NSgaCFCqERP 2fzEIqNUku6AY3UaySwr9cSGfVTW43dSsnghMjJ2kB0UPBBG8E4zdl+hILw9iLVlAqmT AM6gKJ/E1BfWghXzQqE2bQ1MIspKPq57dGATs+Thoydd0S/fjcnG0lY9jN3wpSMALFNj fUkYscE50nw+xMNFPo1xmFHOcU2d24te34j28ys4dr5uCRyunh8DSLnTwLO+iJunqyV2 NZkukep8Xgu6lAxIU/sINW/fOM7jGzAStCKxnFw8I7auiKTmAhU+a7wdMNklnotSTYa1 34QA== X-Gm-Message-State: AAQBX9e8m7iYUSCPeao8eI0DE8YOzDLI64tHDXhSXZddGvDtQle3z3YW tDbEk99pHdDMGNGtPsXd7o0= X-Google-Smtp-Source: AKy350bRqeteWcjnkTIcurqTl1oWKZYh9KZ+a4XXfT1yVbnoTXZe3+iRFNM2lEjTXmNJJHf8PoUGRg== X-Received: by 2002:a17:906:430a:b0:947:5bd8:9523 with SMTP id j10-20020a170906430a00b009475bd89523mr284233ejm.31.1680627266507; Tue, 04 Apr 2023 09:54:26 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-1-233.dynamic.telemach.net. [82.149.1.233]) by smtp.gmail.com with ESMTPSA id 16-20020a170906329000b0093137b1f23fsm6151226ejw.37.2023.04.04.09.54.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 09:54:26 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Paul Kocialkowski , Mauro Carvalho Chehab , Greg Kroah-Hartman , Chen-Yu Tsai , Samuel Holland , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH 16/24] staging: media: sun6i-isp: Convert to platform remove callback returning void Date: Tue, 04 Apr 2023 18:54:24 +0200 Message-ID: <5660511.DvuYhMxLoT@jernej-laptop> In-Reply-To: <20230403154014.2564054-17-u.kleine-koenig@pengutronix.de> References: <20230403154014.2564054-1-u.kleine-koenig@pengutronix.de> <20230403154014.2564054-17-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230404_095430_432944_A0EC48F7 X-CRM114-Status: GOOD ( 12.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 03. april 2023 ob 17:40:06 CEST je Uwe Kleine-K=F6nig = napisal(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig Acked-by: Jernej Skrabec Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel