From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: "Giuseppe Cavallaro" <peppe.cavallaro@st.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Jose Abreu" <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>, "Chen-Yu Tsai" <wens@csie.org>,
"Samuel Holland" <samuel@sholland.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev,
linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de
Subject: Re: [PATCH net-next 10/11] net: stmmac: dwmac-sun8i: Convert to platform remove callback returning void
Date: Sun, 02 Apr 2023 16:41:40 +0200 [thread overview]
Message-ID: <5660915.DvuYhMxLoT@jernej-laptop> (raw)
In-Reply-To: <20230402143025.2524443-11-u.kleine-koenig@pengutronix.de>
Dne nedelja, 02. april 2023 ob 16:30:24 CEST je Uwe Kleine-König napisal(a):
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
For sunxi:
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-02 14:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 14:30 [PATCH net-next 00/11] net: stmmac: Convert to platform remove callback returning void Uwe Kleine-König
2023-04-02 14:30 ` [PATCH net-next 01/11] net: stmmac: Make stmmac_pltfr_remove() return void Uwe Kleine-König
2023-04-02 14:41 ` Jernej Škrabec
2023-04-03 15:55 ` Simon Horman
2023-04-03 20:39 ` Martin Blumenstingl
2023-04-02 14:30 ` [PATCH net-next 02/11] net: stmmac: dwmac-visconti: Make visconti_eth_clock_remove() " Uwe Kleine-König
2023-04-02 17:02 ` Simon Horman
2023-04-03 5:52 ` Uwe Kleine-König
2023-04-02 14:30 ` [PATCH net-next 03/11] net: stmmac: dwmac-qcom-ethqos: Drop an if with an always false condition Uwe Kleine-König
2023-04-03 15:47 ` Simon Horman
2023-04-02 14:30 ` [PATCH net-next 04/11] net: stmmac: dwmac-visconti: Convert to platform remove callback returning void Uwe Kleine-König
2023-04-03 15:46 ` Simon Horman
2023-04-02 14:30 ` [PATCH net-next 05/11] net: stmmac: dwmac-dwc-qos-eth: " Uwe Kleine-König
2023-04-03 15:49 ` Simon Horman
2023-04-02 14:30 ` [PATCH net-next 06/11] net: stmmac: dwmac-qcom-ethqos: " Uwe Kleine-König
2023-04-03 15:49 ` Simon Horman
2023-04-02 14:30 ` [PATCH net-next 07/11] net: stmmac: dwmac-rk: " Uwe Kleine-König
2023-04-03 15:50 ` Simon Horman
2023-04-02 14:30 ` [PATCH net-next 08/11] net: stmmac: dwmac-sti: " Uwe Kleine-König
2023-04-03 15:52 ` Simon Horman
2023-04-02 14:30 ` [PATCH net-next 09/11] net: stmmac: dwmac-stm32: " Uwe Kleine-König
2023-04-03 15:52 ` Simon Horman
2023-04-02 14:30 ` [PATCH net-next 10/11] net: stmmac: dwmac-sun8i: " Uwe Kleine-König
2023-04-02 14:41 ` Jernej Škrabec [this message]
2023-04-03 15:52 ` Simon Horman
2023-04-02 14:30 ` [PATCH net-next 11/11] net: stmmac: dwmac-tegra: " Uwe Kleine-König
2023-04-03 15:54 ` Simon Horman
2023-04-04 11:16 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5660915.DvuYhMxLoT@jernej-laptop \
--to=jernej.skrabec@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=samuel@sholland.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).