From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CEB4C76196 for ; Sun, 2 Apr 2023 14:42:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wn6u3pP+9FgqXbhXqYC6ps3XZn+jhQ37+GS4l6JDFqE=; b=SgpPJsBeIiXj8f OfutMud5dcJaDdi9tr0zv9opBsN/CgoeynzS5fm9BfatX+YAtSp07w+a+6+C+KTf6G9tilP/OMf4C BgZdNgQdxMFU7xSARMY39NDHyeei9IY5Y7YEPp2bBK0pNhY0Hx6zrNip5D1YtobzeBTUoe7YjWonK AwGs/+oD+JqfTC5b7Pl0FZXEUxcdv3rJ9gzBo0vfFiGvVM25QtF1UFxSTt4nnO7q+MpKTN8uDv2Fq i1rALLRCjJPlk0neX503RWXfbacHvaVvA9s20oIhjEdwm/OBep+6TA97J3hzWfSeqG+Ljx6mGlfEa l/MD99cNqQFcFhh1zNLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1piytw-00Ceis-31; Sun, 02 Apr 2023 14:41:48 +0000 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1piytu-00Cegw-2z for linux-arm-kernel@lists.infradead.org; Sun, 02 Apr 2023 14:41:48 +0000 Received: by mail-wr1-x42d.google.com with SMTP id l27so26835464wrb.2 for ; Sun, 02 Apr 2023 07:41:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680446502; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bEt4l1scuvVJz61CdEo1J/wJGcCf7qx7gZaNe6q49Tk=; b=AM6IaoRgryD3mDHhYKjzWlGbOI4PjjiEREetuHxrbI8nRCASKBbID1ipXfMppUGefn SbRKbLaAy9LbJ3V3mYVh1d7MfKEOcTMaYCQgoi2kIqrA8WieblRhcgfY1lBJy2l7AUzC EplF4yW5IeKj4Msbo4Qhegh3MyPtngcY4GgSehJsaeWXcZlkh0ImoFsC1vlwoaBqzZMx 4vAu5vD81iViSQ0u+6NM9bNpQVITK0e1iinU0lKKuoX3lh/VtVQ8biplLPpVXwfrl8cH H+K6jZscXL1FWh8GR95ZawTqsOkOrQbpoOAEwWn6qEyY+R1pr8ctvfOnNibyvJMAgT7h KTbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680446502; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bEt4l1scuvVJz61CdEo1J/wJGcCf7qx7gZaNe6q49Tk=; b=ktF98qDt/6xsSDChbQ/6XTLeqb/QcWuXj5yuRJvI3pt2h6Hlv17sWVret6D5xUUKF2 B6zg4xibF9jZe7U/OsOD9tdV6AlgdidTMxgpi5qgWb4lqbF2RyhLS5b6FBQpJp41uaWh xsPb7yKtNyQ4d/Oa/Ty7w5Z+dqRSiYG4COfAt/wfSsH/9PQJMbgAd/pxAnLhQyzjp6sN 9RN7/w9pNLtp/FU7anTmMPypwA6cCaTz1V3O0vk3GVvNq98tnCZ8SVCiI+s6ZUwvFIX1 CjHxI0HCXYEM6YWZ0VCAvDIAkMJzRqKRRiRLy0sgFT/UB8KMhwb7uqWBx1Y5iIQl6i1X gtQA== X-Gm-Message-State: AAQBX9fZMjX4VunO/A7jbpiide+xPLtKlH7vGUK400vDk+tfAggRArlr 7LYM5Y/0ES9I0KRMx7dJo/Y= X-Google-Smtp-Source: AKy350Yn72Cp3g4kqSIGRXETjmEUB7dsTtjqD1MDsR7d5+bikqDEJ859bvNTN8XhIC4ugyFr+biBQQ== X-Received: by 2002:a5d:58e7:0:b0:2ce:aed6:3f2e with SMTP id f7-20020a5d58e7000000b002ceaed63f2emr23235081wrd.46.1680446502253; Sun, 02 Apr 2023 07:41:42 -0700 (PDT) Received: from jernej-laptop.localnet ([209.198.137.155]) by smtp.gmail.com with ESMTPSA id z6-20020a5d4d06000000b002e6d4ac31a3sm5053895wrt.72.2023.04.02.07.41.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 07:41:41 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chen-Yu Tsai , Samuel Holland , Maxime Coquelin , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de Subject: Re: [PATCH net-next 10/11] net: stmmac: dwmac-sun8i: Convert to platform remove callback returning void Date: Sun, 02 Apr 2023 16:41:40 +0200 Message-ID: <5660915.DvuYhMxLoT@jernej-laptop> In-Reply-To: <20230402143025.2524443-11-u.kleine-koenig@pengutronix.de> References: <20230402143025.2524443-1-u.kleine-koenig@pengutronix.de> <20230402143025.2524443-11-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230402_074146_963878_9DDC7B55 X-CRM114-Status: GOOD ( 11.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne nedelja, 02. april 2023 ob 16:30:24 CEST je Uwe Kleine-K=F6nig napisal(= a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig For sunxi: Acked-by: Jernej Skrabec Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel