Re: [PATCH] arm64: dts: rockchip: add ROCK Pi 4 DTS support

From: Heiko Stuebner <heiko@sntech.de>
To: klaus.goger@theobroma-systems.com
Cc: Mark Rutland <mark.rutland@arm.com>,
	Shohei Maruyama <cheat.sc.linux@outlook.com>,
	devicetree@vger.kernel.org,
	Akash Gajjar <Akash_Gajjar@mentor.com>,
	linux-kernel@vger.kernel.org,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	Rob Herring <robh+dt@kernel.org>,
	Pragnesh_Patel@mentor.com, Oskari Lemmela <oskari@lemmela.net>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Olof Johansson <olof@lixom.net>,
	linux-rockchip@lists.infradead.org, Levin Du <djw@t-chip.com.cn>,
	Liang Chen <cl@rock-chips.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: add ROCK Pi 4 DTS support
Date: Tue, 01 Jan 2019 13:20:26 +0100	[thread overview]
Message-ID: <5662913.pS8bTmJHpa@phil> (raw)
In-Reply-To: <6B09C29B-CACB-4F71-A812-BE538AE6D996@theobroma-systems.com>

Hi Pragnesh, Klaus,

Am Dienstag, 1. Januar 2019, 10:54:55 CET schrieb klaus.goger@theobroma-systems.com:
> > On 01.01.2019, at 09:08, <Pragnesh_Patel@mentor.com> <Pragnesh_Patel@mentor.com> wrote:
> > 
> > From: Akash Gajjar <Akash_Gajjar@mentor.com>
> > 
> > ROCK Pi 4 is RK3399 based SBC from radxa.com. board has a 1G/2G/4G lpddr4, CSI,
> > DSI, HDMI, OTG, USB 2.0, USB 3.0, 10/100/1000 RGMII Ethernet Phy, es8316 codec,
> > POE, WIFI (for Model B only), PCIE M.2 support on board.
> > 
> > This patch enables
> > - HDMI Display
> > - Console
> > - MMC, EMMC
> > - USB 2.0, USB-3.0
> > - Ethernet
> > 
> > Signed-off-by: Akash Gajjar <Akash_Gajjar@mentor.com>
> > Signed-off-by: Pragnesh Patel <Pragnesh_Patel@mentor.com>

> > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> > index de0c406c20cc..3fab0a3e4eeb 100644
> > --- a/arch/arm64/boot/dts/rockchip/Makefile
> > +++ b/arch/arm64/boot/dts/rockchip/Makefile
> > @@ -18,6 +18,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-gru-scarlet-inx.dtb
> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-gru-scarlet-kd.dtb
> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-puma-haikou.dtb
> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-roc-pc.dtb
> > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock-pi-4.dtb
> 
> sort(1) would put it before roc-pc

I'd keep it were it is right now, aka after roc- and before roc960.
Otherwise we would need to resort the whole list to keep it consistent ;-)

And I really want to minimize resorts, so just keep it were it is now
and looks sorted :-D

[...]

> > +	usb2 {
> > +		vcc5v0_host_en: vcc5v0-host-en {
> > +			rockchip,pins = <4 RK_PD1 RK_FUNC_GPIO &pcfg_pull_none>;
> > +		};
> > +	};
> 
> Maybe use the GPIO bank macros here?
> 1 = RK_GPIO1, 2 = RK_GPIO2 and so forth.

Actually the other way around please :-)
Aka just use numbers for the gpio bank in new files
and the pin defines RK_PD1 for the pins.

The RK_GPIO1 -> 1, etc... defines don't really bring additional
usefulnes, so I encourage not using them in new boards.

> > +&sdmmc {
> > +	bus-width = <4>;
> > +	cap-mmc-highspeed;
> > +	cap-sd-highspeed;
> > +	cd-gpios = <&gpio0 7 GPIO_ACTIVE_LOW>;
> 
> RK_PA7 for consistency.

yep, here the mapping iomux 4*8 pins <-> gpio controllers (32 pins)
is non intuitive and makes it more difficult, so the defines actually help
in following schematics.

Heiko

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel