linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi][PATCH 0/2] ARM: dts: sun4i: mk802 variant patches
Date: Wed, 9 Dec 2015 10:29:21 +0100	[thread overview]
Message-ID: <5667F471.1090505@redhat.com> (raw)
In-Reply-To: <1449600534-5098-1-git-send-email-codekipper@gmail.com>

Hi Marcus,

On 08-12-15 19:48, codekipper at gmail.com wrote:
> From: Marcus Cooper <codekipper@gmail.com>
>
> This patch series splits the mk802 dts into common include file which
> can be shared with the mk802+ device. The only difference that I can
> see between this and the original device is that it has an internal
> microphone.
>
> With that in mind we can either leave things as they are and enable
> the capture to the original mk802 dts or apply this patch to distinguish
> between the two devices.

Thanks for your work on this, but I do not think that it is a good idea
to differentiate between the different mk802 (not mk802-ii) models, there
are many variants and the chances of a user knowing exactly which variant
he has are small.

So instead we should do the same as with the q8 formfactor tablets and
strive to have a single dts which works everywhere. Here that seems
easy enough, just always enable the mic input (once we have support for
it), this will give people without the mic just noise if they try to use
it but that is not a big deal IMHO.

Regards,

Hans

      parent reply	other threads:[~2015-12-09  9:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-08 18:48 [linux-sunxi][PATCH 0/2] ARM: dts: sun4i: mk802 variant patches codekipper at gmail.com
2015-12-08 18:48 ` [linux-sunxi][PATCH 1/2] ARM: dts: sun4i: Create common dtsi for mk802 codekipper at gmail.com
2015-12-08 18:48 ` [linux-sunxi][PATCH 2/2] ARM: dts: sun4i: Add rikomagic mk802+ board codekipper at gmail.com
2015-12-08 22:56   ` Julian Calaby
2015-12-09  6:25     ` Code Kipper
2015-12-09  9:20 ` [linux-sunxi][PATCH 0/2] ARM: dts: sun4i: mk802 variant patches Maxime Ripard
2015-12-09  9:29 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5667F471.1090505@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).