From: daniel@zonque.org (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: pxa: mark raumfeld init functions as __maybe_unused
Date: Wed, 9 Dec 2015 18:05:36 +0100 [thread overview]
Message-ID: <56685F60.6030200@zonque.org> (raw)
In-Reply-To: <2245032.bpQt17WIoe@wuerfel>
On 12/09/2015 05:52 PM, Arnd Bergmann wrote:
> The raumfeld.c file contains three similar machine definitions,
> each with their own init function. If one or more of them are
> disabled, we get compile-time warnings:
>
> arm/mach-pxa/raumfeld.c:1070:123: warning: 'raumfeld_connector_init' defined but not used [-Wunused-function]
> arm/mach-pxa/raumfeld.c:1082:123: warning: 'raumfeld_speaker_init' defined but not used [-Wunused-function]
>
> This marks the functions as __maybe_unused to avoid the warnings.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Daniel Mack <daniel@zonque.org>
Thanks!
>
> diff --git a/arch/arm/mach-pxa/raumfeld.c b/arch/arm/mach-pxa/raumfeld.c
> index 0f67d94be297..8347d87a713d 100644
> --- a/arch/arm/mach-pxa/raumfeld.c
> +++ b/arch/arm/mach-pxa/raumfeld.c
> @@ -1046,7 +1046,7 @@ static void __init raumfeld_common_init(void)
> i2c_register_board_info(1, &raumfeld_pwri2c_board_info, 1);
> }
>
> -static void __init raumfeld_controller_init(void)
> +static void __init __maybe_unused raumfeld_controller_init(void)
> {
> int ret;
>
> @@ -1067,7 +1067,7 @@ static void __init raumfeld_controller_init(void)
> raumfeld_w1_init();
> }
>
> -static void __init raumfeld_connector_init(void)
> +static void __init __maybe_unused raumfeld_connector_init(void)
> {
> pxa3xx_mfp_config(ARRAY_AND_SIZE(raumfeld_connector_pin_config));
> spi_register_board_info(ARRAY_AND_SIZE(connector_spi_devices));
> @@ -1079,7 +1079,7 @@ static void __init raumfeld_connector_init(void)
> raumfeld_common_init();
> }
>
> -static void __init raumfeld_speaker_init(void)
> +static void __init __maybe_unused raumfeld_speaker_init(void)
> {
> pxa3xx_mfp_config(ARRAY_AND_SIZE(raumfeld_speaker_pin_config));
> spi_register_board_info(ARRAY_AND_SIZE(speaker_spi_devices));
>
prev parent reply other threads:[~2015-12-09 17:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 16:52 [PATCH] ARM: pxa: mark raumfeld init functions as __maybe_unused Arnd Bergmann
2015-12-09 17:05 ` Daniel Mack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56685F60.6030200@zonque.org \
--to=daniel@zonque.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).