From: daniel.thompson@linaro.org (Daniel Thompson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/4] printk/nmi: Increase the size of NMI buffer and make it configurable
Date: Mon, 14 Dec 2015 10:28:47 +0000 [thread overview]
Message-ID: <566E99DF.6050008@linaro.org> (raw)
In-Reply-To: <20151211232113.GZ8644@n2100.arm.linux.org.uk>
On 11/12/15 23:21, Russell King - ARM Linux wrote:
> As I explained when I did that work, the vast majority of ARM platforms
> are unable to trigger anything like a NMI - the FIQ is something that's
> generally a property of the secure monitor, and is not accessible to
> Linux. However, there are platforms where it is accessible.
>
> The work to add the FIQ-based variant never happened (I've no idea what
> happened to that part, Daniel seems to have lost interest in working on
> it.) So, what we have is the IRQ-based variant merged in mainline, which
> would be the fallback for the "FIQ not available" cases, and I carry a
> local hack in my tree which provides the FIQ-based version - but if it
> were to trigger, it takes out all interrupts (hence why I've not merged
> my hack.)
>
> I think the reason that the FIQ-based variant has never really happened
> is that hooking into the interrupt controller code to clear down the FIQ
> creates such a horrid layering violation, and also a locking mess that
> I suspect it's just been given up with.
I haven't quite given up; I'm still looking into this stuff. However
you're certainly right that connecting the FIQ handler to the GIC code
in an elegant way is tough.
I've been working in parallel on an arm64 implementation with the result
that I'm now two lumps of code that are almost, but not quite, ready.
Right now I hope to share latest arm code fairly late in the this
devcycle (for review rather than merge) followed up with a new version
very early in v4.6. Even now I think the code needs a long soak in -next
just in case there are any lurking regressions on particular platforms.
I don't expect anyone to base decisions on my aspirations above but
would like to reassure Russell that I haven't given up on it.
Daniel.
prev parent reply other threads:[~2015-12-14 10:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 13:21 [PATCH v3 0/4] Cleaning printk stuff in NMI context Petr Mladek
2015-12-09 13:21 ` [PATCH v3 1/4] printk/nmi: Generic solution for safe printk in NMI Petr Mladek
2015-12-09 23:50 ` Andrew Morton
2015-12-10 15:26 ` Petr Mladek
2015-12-09 13:21 ` [PATCH v3 2/4] printk/nmi: Use IRQ work only when ready Petr Mladek
2015-12-09 13:21 ` [PATCH v3 3/4] printk/nmi: Warn when some message has been lost in NMI context Petr Mladek
2015-12-09 13:21 ` [PATCH v3 4/4] printk/nmi: Increase the size of NMI buffer and make it configurable Petr Mladek
2015-12-11 11:10 ` Geert Uytterhoeven
2015-12-11 12:41 ` Petr Mladek
2015-12-11 12:47 ` Arnd Bergmann
2015-12-11 12:50 ` Geert Uytterhoeven
2015-12-11 22:57 ` Andrew Morton
2015-12-11 23:21 ` Russell King - ARM Linux
2015-12-11 23:26 ` Jiri Kosina
2015-12-18 10:18 ` Daniel Thompson
2015-12-18 11:29 ` Peter Zijlstra
2015-12-18 12:11 ` Peter Zijlstra
2015-12-18 23:03 ` Andrew Morton
2015-12-18 14:52 ` Petr Mladek
2015-12-18 17:00 ` Daniel Thompson
2016-03-01 14:04 ` Daniel Thompson
2015-12-11 23:30 ` Andrew Morton
2015-12-15 14:26 ` Petr Mladek
2015-12-17 22:38 ` Andrew Morton
2015-12-18 16:18 ` Petr Mladek
2015-12-14 10:28 ` Daniel Thompson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566E99DF.6050008@linaro.org \
--to=daniel.thompson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).