From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] cpuidle: avoid module usage in non-modular code
Date: Mon, 14 Dec 2015 22:17:55 +0100 [thread overview]
Message-ID: <566F3203.5010009@linaro.org> (raw)
In-Reply-To: <1450051032-32329-1-git-send-email-paul.gortmaker@windriver.com>
On 12/14/2015 12:57 AM, Paul Gortmaker wrote:
> This series of commits is a part of a larger project to ensure
> people don't reference modular support functions in non-modular
> code. Overall there was roughly 5k lines of dead code in the
> kernel due to this. So far we've fixed several areas, like tty,
> x86, net, ... and we continue to work on other areas.
>
> There are several reasons to not use module support for code that
> can never be built as a module, but the big ones are:
>
> (1) it is easy to accidentally code up unused module_exit and remove code
> (2) it can be misleading when reading the source, thinking it can be
> modular when the Makefile and/or Kconfig prohibit it
> (3) it requires the include of the module.h header file which in turn
> includes nearly everything else.
>
> Fortunately for cpuidle, the changes are largely trivial and change
> zero runtime. All the changes here just remap the modular functions
> onto the non-modular ones that they would be remapped onto anyway.
>
> Changes are against linux-next and compile tested on ARM allmodconfig.
> I've Cc'd ARM list because all of these are used on ARM, but I'm
> thinking these probably can go in via the PM tree.
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2015-12-14 21:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-13 23:57 [PATCH 0/3] cpuidle: avoid module usage in non-modular code Paul Gortmaker
2015-12-13 23:57 ` [PATCH 1/3] drivers/cpuidle: make cpuidle-clps711x.c explicitly non-modular Paul Gortmaker
2015-12-13 23:57 ` [PATCH 2/3] drivers/cpuidle: make cpuidle-ux500.c " Paul Gortmaker
2015-12-13 23:57 ` [PATCH 3/3] drivers/cpuidle: make cpuidle-exynos.c " Paul Gortmaker
2015-12-14 21:17 ` Daniel Lezcano [this message]
2015-12-14 21:31 ` [PATCH 0/3] cpuidle: avoid module usage in non-modular code Rafael J. Wysocki
2015-12-14 21:32 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566F3203.5010009@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).