linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: davinci: only select WT cache if cache is enabled
@ 2015-12-10 13:19 Arnd Bergmann
  2015-12-15  9:52 ` Sekhar Nori
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2015-12-10 13:19 UTC (permalink / raw)
  To: linux-arm-kernel

The DA830 chip only works if the dcache is in writethrough mode,
but that produces a harmless Kconfig warning if the cache happens
to be disabled:

warning: (ARCH_DAVINCI_DA830) selects CPU_DCACHE_WRITETHROUGH which has unmet direct dependencies ((CPU_ARM740T || CPU_ARM920T || CPU_ARM922T || CPU_ARM925T || CPU_ARM926T || CPU_ARM940T || CPU_ARM946E || CPU_ARM1020 || CPU_FA526) && !CPU_DCACHE_DISABLE)

This makes the select conditional so we don't have to worry
about the warning in randconfig builds any more.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---

diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
index 88233824d1fe..83e0f40f9ff1 100644
--- a/arch/arm/mach-davinci/Kconfig
+++ b/arch/arm/mach-davinci/Kconfig
@@ -34,7 +34,8 @@ config ARCH_DAVINCI_DA830
 	bool "DA830/OMAP-L137/AM17x based system"
 	depends on !ARCH_DAVINCI_DMx || AUTO_ZRELADDR
 	select ARCH_DAVINCI_DA8XX
-	select CPU_DCACHE_WRITETHROUGH # needed on silicon revs 1.0, 1.1
+	# needed on silicon revs 1.0, 1.1:
+	select CPU_DCACHE_WRITETHROUGH if !CPU_DCACHE_DISABLE
 	select CP_INTC
 
 config ARCH_DAVINCI_DA850

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: davinci: only select WT cache if cache is enabled
  2015-12-10 13:19 [PATCH] ARM: davinci: only select WT cache if cache is enabled Arnd Bergmann
@ 2015-12-15  9:52 ` Sekhar Nori
  0 siblings, 0 replies; 2+ messages in thread
From: Sekhar Nori @ 2015-12-15  9:52 UTC (permalink / raw)
  To: linux-arm-kernel

On Thursday 10 December 2015 06:49 PM, Arnd Bergmann wrote:
> The DA830 chip only works if the dcache is in writethrough mode,
> but that produces a harmless Kconfig warning if the cache happens
> to be disabled:
> 
> warning: (ARCH_DAVINCI_DA830) selects CPU_DCACHE_WRITETHROUGH which has unmet direct dependencies ((CPU_ARM740T || CPU_ARM920T || CPU_ARM922T || CPU_ARM925T || CPU_ARM926T || CPU_ARM940T || CPU_ARM946E || CPU_ARM1020 || CPU_FA526) && !CPU_DCACHE_DISABLE)
> 
> This makes the select conditional so we don't have to worry
> about the warning in randconfig builds any more.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied.

Thanks,
Sekhar

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-12-15  9:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-10 13:19 [PATCH] ARM: davinci: only select WT cache if cache is enabled Arnd Bergmann
2015-12-15  9:52 ` Sekhar Nori

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).