From mboxrd@z Thu Jan  1 00:00:00 1970
From: linux@roeck-us.net (Guenter Roeck)
Date: Fri, 18 Dec 2015 08:20:30 -0800
Subject: [PATCH] hwmon: sht15 needs CONFIG_BITREVERSE
In-Reply-To: <1562989.nyG23Y3QQo@wuerfel>
References: <1562989.nyG23Y3QQo@wuerfel>
Message-ID: <5674324E.6050908@roeck-us.net>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On 12/18/2015 06:52 AM, Arnd Bergmann wrote:
> If CONFIG_BITREVERSE is not built-in, the sht15 driver fails to link:
>
> drivers/built-in.o: In function `sht15_crc8':
> drivers/hwmon/sht15.c:195: undefined reference to `byte_rev_table'
>
> This adds a Kconfig 'select' statement, like all other users of
> bitrev.h have it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 33836ee98533 ("hwmon:change sht15_reverse()")

Good catch. Applied.

Thanks,
Guenter

>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 4a6e7c217329..60fb80bd353d 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -1207,6 +1207,7 @@ config SENSORS_PWM_FAN
>   config SENSORS_SHT15
>   	tristate "Sensiron humidity and temperature sensors. SHT15 and compat."
>   	depends on GPIOLIB || COMPILE_TEST
> +	select BITREVERSE
>   	help
>   	  If you say yes here you get support for the Sensiron SHT10, SHT11,
>   	  SHT15, SHT71, SHT75 humidity and temperature sensors.
>
>