From: kernel@martin.sperl.org (Martin Sperl)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ARM: bcm2835: Switch to using the new clock driver support.
Date: Mon, 21 Dec 2015 12:51:27 +0100 [thread overview]
Message-ID: <5677E7BF.3020404@martin.sperl.org> (raw)
In-Reply-To: <1441562263-19888-5-git-send-email-eric@anholt.net>
On 06.09.2015 19:57, Eric Anholt wrote:
>
> + clocks: cprman at 7e101000 {
> + compatible = "brcm,bcm2835-cprman";
> + #clock-cells = <1>;
> + reg = <0x7e101000 0x2000>;
> +
> + /* CPRMAN derives everything from the platform's
> + * oscillator.
> + */
> + clocks = <&clk_osc>;
> + };
> +
>
This actually breaks i2s because of an overlap in registers:
[ 12.734352] bcm2835-i2s 20203000.i2s: can't request region for
resource [mem 0x20101098-0x2010109f]
[ 12.826571] bcm2835-i2s: probe of 20203000.i2s failed with error -16
here the corresponding section for i2s in /arch/arm/boot/dts/bcm2835.dtsi:
i2s: i2s at 7e203000 {
compatible = "brcm,bcm2835-i2s";
reg = <0x7e203000 0x20>,
<0x7e101098 0x02>;
dmas = <&dma 2>,
<&dma 3>;
dma-names = "tx", "rx";
status = "disabled";
};
Note that actually the PCM/I2S reg-range should be (off by 4):
reg = <0x7e203000 0x24>;
(see also: https://github.com/raspberrypi/linux/pull/1079)
Ciao,
Martin
next prev parent reply other threads:[~2015-12-21 11:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-06 17:57 Raspberry Pi native clock driver Eric Anholt
2015-09-06 17:57 ` [PATCH 1/4] clk: bcm2835: Move under bcm/ with other Broadcom SoC clk drivers Eric Anholt
2015-09-07 6:48 ` Lee Jones
2015-09-08 19:22 ` Stephen Boyd
2015-10-01 14:43 ` Lee Jones
2015-09-06 17:57 ` [PATCH 2/4] clk: bcm2835: Add binding docs for the new platform clock driver Eric Anholt
2015-09-06 17:57 ` [PATCH 3/4] clk: bcm2835: Add support for programming the audio domain clocks Eric Anholt
2015-09-10 21:35 ` Eric Anholt
2015-09-06 17:57 ` [PATCH 4/4] ARM: bcm2835: Switch to using the new clock driver support Eric Anholt
2015-12-21 11:51 ` Martin Sperl [this message]
2015-12-21 12:42 ` Stefan Wahren
2015-12-21 15:17 ` Martin Sperl
2015-12-21 18:08 ` Stefan Wahren
2015-12-21 18:32 ` Martin Sperl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5677E7BF.3020404@martin.sperl.org \
--to=kernel@martin.sperl.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).