linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: vz@mleia.com (Vladimir Zapolskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] arm: dts: phy3250: add SD fixed regulator
Date: Mon, 21 Dec 2015 18:58:50 +0200	[thread overview]
Message-ID: <56782FCA.2050504@mleia.com> (raw)
In-Reply-To: <5677F3DC.6070402@cogentembedded.com>

Hell Sergei,

On 21.12.2015 14:43, Sergei Shtylyov wrote:
> Hello.
> 
> On 12/20/2015 2:32 AM, Vladimir Zapolskiy wrote:
> 
>> The change adds fixed voltage regulator for SD controller, ARM MMCI
>> controller driver uses it to control card power management.
>>
>> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
>> ---
>>   arch/arm/boot/dts/phy3250.dts | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/phy3250.dts b/arch/arm/boot/dts/phy3250.dts
>> index 34e15fd..5465b9e 100644
>> --- a/arch/arm/boot/dts/phy3250.dts
>> +++ b/arch/arm/boot/dts/phy3250.dts
>> @@ -45,6 +45,15 @@
>>   			enable-active-high;
>>   			regulator-boot-on;
>>   		};
>> +
>> +		sd_reg: fixed-regulator at 2 {
> 
>     Please just "regulator at 2", to comply with the ePAPR standard.

thanks for review, just for my information, do I understand correctly
that you reference to "Generic Names Recommendation" ?

I have no objection to generalize device tree node name as you
suggested, will do it.

With best wishes,
Vladimir

  reply	other threads:[~2015-12-21 16:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-19 23:32 [PATCH 0/3] arm: lpc32xx: remove direct control of GPIOs from shared mach file Vladimir Zapolskiy
2015-12-19 23:32 ` [PATCH 1/3] arm: dts: phy3250: add lcd and backlight fixed regulators Vladimir Zapolskiy
2015-12-19 23:32 ` [PATCH 2/3] arm: dts: phy3250: add SD fixed regulator Vladimir Zapolskiy
2015-12-19 23:48   ` Russell King - ARM Linux
2015-12-20  2:14     ` Vladimir Zapolskiy
2015-12-20  2:22   ` [PATCH v2 " Vladimir Zapolskiy
2015-12-21 12:43   ` [PATCH " Sergei Shtylyov
2015-12-21 16:58     ` Vladimir Zapolskiy [this message]
2015-12-21 17:04       ` Sergei Shtylyov
2015-12-19 23:32 ` [PATCH 3/3] arm: lpc32xx: remove direct control of GPIOs from shared mach file Vladimir Zapolskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56782FCA.2050504@mleia.com \
    --to=vz@mleia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).