linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: andre.przywara@arm.com (André Przywara)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 2/5] crypto: sunxi-ss: fix min3() call to match types
Date: Wed, 23 Dec 2015 00:07:41 +0000	[thread overview]
Message-ID: <5679E5CD.2070103@arm.com> (raw)
In-Reply-To: <201512222306.58681.arnd@arndb.de>

Hi Arnd,
On 12/22/15 22:06, Arnd Bergmann wrote:
> On Tuesday 22 December 2015, Andre Przywara wrote:
>> The min3() macro expects all arguments to be of the same type (or
>> size at least). While two arguments are ints or u32s, one is size_t,
>> which does not match on 64-bit architectures.
>> Cast the size_t to u32 to make min3() happy. In this context here the
>> length should never exceed 32 bits anyway.
>>
>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> 
> Looks correct, but a bit ugly. Could we avoid the casts by using
> temporary variables to keep the size_t based data?

I guess this gets even uglier, but I found a better solution by
promoting the other involved variables to size_t in this function. This
works nicely for most of the cases, I just need two size_t casts now.
Will send an updated version soon.

Cheers,
Andre.

  reply	other threads:[~2015-12-23  0:07 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-22 12:27 [RFC PATCH 0/5] arm64: prepare for basic Allwinner support Andre Przywara
2015-12-22 12:27 ` [RFC PATCH 1/5] drivers: sunxi-rsb: fix error output type Andre Przywara
2015-12-22 22:02   ` Arnd Bergmann
2015-12-27 22:03   ` Maxime Ripard
2015-12-22 12:27 ` [RFC PATCH 2/5] crypto: sunxi-ss: fix min3() call to match types Andre Przywara
2015-12-22 22:06   ` Arnd Bergmann
2015-12-23  0:07     ` André Przywara [this message]
2016-01-04 14:20   ` Uwe Kleine-König
2015-12-22 12:27 ` [RFC PATCH 3/5] crypto: sunxi-ss: fix dev_dbg() output type Andre Przywara
2015-12-22 22:07   ` Arnd Bergmann
2015-12-24 12:56   ` Corentin LABBE
2015-12-27 22:05   ` Maxime Ripard
2015-12-22 12:27 ` [RFC PATCH 4/5] irqchip: sun4i: fix compilation outside of arch/arm Andre Przywara
2015-12-22 22:08   ` Arnd Bergmann
2015-12-27 22:04   ` Maxime Ripard
2015-12-22 12:27 ` [RFC PATCH 5/5] arm64: Introduce Allwinner SoC config option Andre Przywara
2015-12-22 22:09   ` Arnd Bergmann
2016-01-04 11:26   ` Maxime Ripard
2016-01-04 12:12     ` Arnd Bergmann
2016-01-06 21:03       ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5679E5CD.2070103@arm.com \
    --to=andre.przywara@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).