From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEDE2C433DF for ; Thu, 27 Aug 2020 11:34:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74F4022B40 for ; Thu, 27 Aug 2020 11:34:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rr/RX9LX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74F4022B40 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hC+XX8yhs4M+klu/bbK3vPokO9xbqqwWAUQ5EIZpZHI=; b=rr/RX9LX5BmlYnnI7ArVlcr/F BPfh4lXv6MeDhFqs7izq9GFxQfdnOabhH+VU9psKcEfSG3SDCr99foXCFwuutD14+6grr254KcWG+ oo+WBao2geXGzlv8q9+69KmNVykqEN3A+JU1ThskAo2HF3e/Q+tYhWIOZXNyJe5C4Q3iDrNtQB21/ yX4G9jlf+XmgzWvIigKK4CfNc7sduaBh1nzVt9BBE7DJs/xEZ47BxL7+2/G0McxRakE49KuB25RfY FZUlyA3BYsBpVAL7ffOMzTp91AdY76jp0e4x8jVqqfRA+INMb6FtgupZMZod95cIUHI1V+9lt1u9I FIAGnaLGA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBG9t-00077k-Mv; Thu, 27 Aug 2020 11:33:33 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBG9r-00076y-2s for linux-arm-kernel@lists.infradead.org; Thu, 27 Aug 2020 11:33:31 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 38EF91045; Thu, 27 Aug 2020 04:33:30 -0700 (PDT) Received: from [192.168.1.190] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 21F033F68F; Thu, 27 Aug 2020 04:33:28 -0700 (PDT) Subject: Re: [PATCH 31/35] kasan, arm64: implement HW_TAGS runtime To: Catalin Marinas , Andrey Konovalov References: <4e86d422f930831666137e06a71dff4a7a16a5cd.1597425745.git.andreyknvl@google.com> <20200827104517.GH29264@gaia> From: Vincenzo Frascino Message-ID: <567f90b6-fa25-6ef3-73b8-45462cc7ceb2@arm.com> Date: Thu, 27 Aug 2020 12:35:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200827104517.GH29264@gaia> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200827_073331_182328_43FDB85E X-CRM114-Status: GOOD ( 17.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Marco Elver , Elena Petrova , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , Andrew Morton , Evgenii Stepanov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/27/20 11:45 AM, Catalin Marinas wrote: > On Fri, Aug 14, 2020 at 07:27:13PM +0200, Andrey Konovalov wrote: >> diff --git a/mm/kasan/mte.c b/mm/kasan/mte.c >> new file mode 100644 >> index 000000000000..43b7d74161e5 >> --- /dev/null >> +++ b/mm/kasan/mte.c > > Since this is an arm64-specific kasan backend, I wonder whether it makes > more sense to keep it under arch/arm64 (mte-kasan.c). > Yes I agree, I had a similar comment in patch 25. I think we should implement the mte backend entirely in arch code because other architectures might want to enable the feature (e.g. Sparc ADI). >> diff --git a/mm/kasan/report_mte.c b/mm/kasan/report_mte.c >> new file mode 100644 >> index 000000000000..dbbf3aaa8798 >> --- /dev/null >> +++ b/mm/kasan/report_mte.c > > Same for this one. > -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel