From mboxrd@z Thu Jan 1 00:00:00 1970 From: grygorii.strashko@ti.com (Grygorii Strashko) Date: Mon, 28 Dec 2015 13:59:27 +0200 Subject: [PATCH v2 1/3] wlcore/wl12xx: spi: add power operation function In-Reply-To: <56801C78.9040102@compulab.co.il> References: <1450971335-15961-1-git-send-email-uri.mashiach@compulab.co.il> <1450971335-15961-2-git-send-email-uri.mashiach@compulab.co.il> <567C1E3B.3020404@ti.com> <56801C78.9040102@compulab.co.il> Message-ID: <5681241F.1060603@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/27/2015 07:14 PM, Uri Mashiach wrote: > Hello Grygorii, > > On 12/24/2015 06:32 PM, Grygorii Strashko wrote: >> On 12/24/2015 05:35 PM, Uri Mashiach wrote: >>> The power function uses a consumer regulator access to update the WiFi >>> enable GPIO value. >>> >>> Signed-off-by: Uri Mashiach >>> --- >>> v1 -> v2: oops fix was removed to a separate fix. >>> >>> drivers/net/wireless/ti/wlcore/spi.c | 37 >>> ++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 37 insertions(+) >>> >>> diff --git a/drivers/net/wireless/ti/wlcore/spi.c >>> b/drivers/net/wireless/ti/wlcore/spi.c >>> >> >> [...] >> >>> + >>> static struct wl1271_if_operations spi_ops = { >>> .read = wl12xx_spi_raw_read, >>> .write = wl12xx_spi_raw_write, >>> .reset = wl12xx_spi_reset, >>> .init = wl12xx_spi_init, >>> + .power = wl12xx_spi_set_power, >>> .set_block_size = NULL, >>> }; >>> >>> @@ -353,6 +384,12 @@ static int wl1271_probe(struct spi_device *spi) >>> * comes from the board-peripherals file */ >>> spi->bits_per_word = 32; >>> >>> + glue->reg = devm_regulator_get(&spi->dev, "vwlan"); >>> + if (IS_ERR(glue->reg)) { >> >> It will be more correct to handle -EPROBE_DEFER here also. Like: >> if (PTR_ERR(glue->reg) == -EPROBE_DEFER) >> return PTR_ERR(glue->reg); >> > > It seems that the IS_ERR(glue->reg) condition covers the EPROBE_DEFER case. True. But this is not an error and it's common practice do not print any log messages in this case from driver :) > >>> + dev_err(glue->dev, "can't get regulator\n"); >>> + return PTR_ERR(glue->reg); >>> + } >>> + >>> ret = spi_setup(spi); >>> if (ret < 0) { >>> dev_err(glue->dev, "spi_setup failed\n"); >>> >> >> > -- regards, -grygorii