From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30BDFCDD1B8 for ; Fri, 27 Sep 2024 15:23:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Vqw3PjeLOeMJcD3pXhUclj4hOK93NrhKi4AUJLM7Kt8=; b=FvfckUCWz9/l1FurFmSOVWQwmQ pWk/sxTo0jGGYqO7J9UpuiX2B0WUMBBqZDuADbDj1oFo5XxD+dN+Xu/qrmeRGglkaHdiPEUAjBt+h bMl4ZJib+f1svbkbhIOScsZXA1mwI1p7h7OkO7uXu8uODx7Zn+KLL48pNQNgiYdltyZRK/8hsIdnT WJiGK3XNeaqy508kYYX2yFN700PYVzN1sijm3gBakL7k+Ow8C3VND7vTrVp19QBXz4QGKXYiokfzh eLTHP64P7jeY1qJbsCSev+ohwlHPfAyM9kRdJBORE2FUufNnu9JqnPwp6fZQyX78FbC2q3HGuTl/0 f9cyviOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1suCnu-0000000BaKr-2EgQ; Fri, 27 Sep 2024 15:22:46 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1suCmh-0000000Ba6e-48Kk for linux-arm-kernel@lists.infradead.org; Fri, 27 Sep 2024 15:21:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BE0A314BF; Fri, 27 Sep 2024 08:21:57 -0700 (PDT) Received: from [10.1.37.46] (e122027.cambridge.arm.com [10.1.37.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CB4B83F587; Fri, 27 Sep 2024 08:21:21 -0700 (PDT) Message-ID: <56886e2e-b5ce-4753-b36f-43d1d7ac427b@arm.com> Date: Fri, 27 Sep 2024 16:21:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 19/19] virt: arm-cca-guest: TSM_REPORT support for realms To: "Aneesh Kumar K.V" , kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Gavin Shan , Shanker Donthineni , Alper Gun , Sami Mujawar References: <20240819131924.372366-1-steven.price@arm.com> <20240819131924.372366-20-steven.price@arm.com> From: Steven Price Content-Language: en-GB In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240927_082132_111745_3EBAE9F0 X-CRM114-Status: GOOD ( 12.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02/09/2024 04:53, Aneesh Kumar K.V wrote: > Steven Price writes: > >> From: Sami Mujawar > > ... > >> --- /dev/null >> +++ b/drivers/virt/coco/arm-cca-guest/Kconfig >> @@ -0,0 +1,11 @@ >> +config ARM_CCA_GUEST >> + tristate "Arm CCA Guest driver" >> + depends on ARM64 >> + default m >> + select TSM_REPORTS >> + help >> + The driver provides userspace interface to request and >> + attestation report from the Realm Management Monitor(RMM). >> + >> + If you choose 'M' here, this module will be called >> + arm-cca-guest. >> > > Can we rename the generic Kconfig variable to ARM_CCA_TSM_REPORT?. Also > should the directory be arm64-cca-guest? This matches the existing sev-guest and tdx-guest directories (and SEV_GUEST/TDX_GUEST_DRIVER kconfig), although I agree it's not great naming as it stands. But I'm also wondering if this will one day expand to include some other communication with the RMM. For example I know it's been discussed whether the guest should have involvement with firmware updates or migration to another host. So there's a reasonable chance we could end up renaming it back to a general "arm_cca_guest" if it grows more capabilities in the future. Steve