From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 25 Feb 2014 16:59:50 +0100 Subject: [PATCH 21/21] ARM: Kirkwood: Remove DT support In-Reply-To: <20140225150942.GF3793@kw.sim.vm.gnt> References: <1391730137-14814-1-git-send-email-andrew@lunn.ch> <201402251636.15257.arnd@arndb.de> <20140225150942.GF3793@kw.sim.vm.gnt> Message-ID: <5689865.yp2cJ53QNJ@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 25 February 2014 16:09:44 Simon Guinot wrote: > On Tue, Feb 25, 2014 at 04:36:14PM +0100, Arnd Bergmann wrote: > > On Tuesday 25 February 2014, Simon Guinot wrote: > > > On Tue, Feb 25, 2014 at 01:44:23PM +0100, Arnd Bergmann wrote: > > > > I just took a brief look at the LED driver. I think it would be > > > > reasonable to move almost all of the platform_data into the driver > > > > itself and associate the two versions with distinct "compatible" > > > > strings. That works in this particular case because while the driver > > > > is generic enough to handle other cases, I also wouldn't expect > > > > it to ever get used again on another platform. > > > > > > Actually, this driver is also used by the Atom-based LaCie NASes. > > > Mainline support for this platforms should be provided soon. > > > > Do you use DT for those machines as well, or how do you get the > > data into the driver there? > > We are using the old fashion platform_device mechanism. The resources > are defined in some board-setup files stored in the arch/x86/platform > repository. Then better be quick, before the x86 maintainers figure out what kind of mess they are getting into, if they want to support lots of embedded machines in the future. ;-) Arnd