* next-20160104 build: 3 failures 15 warnings (next-20160104) [not found] <E1aG3zo-0000gt-2t@optimist> @ 2016-01-04 15:35 ` Mark Brown 2016-01-05 1:04 ` Rafael J. Wysocki 2016-01-04 16:50 ` Mark Brown 1 sibling, 1 reply; 5+ messages in thread From: Mark Brown @ 2016-01-04 15:35 UTC (permalink / raw) To: linux-arm-kernel On Mon, Jan 04, 2016 at 12:12:20PM +0000, Build bot for Mark Brown wrote: Today's linux-next fails to build for arm64 due to 44d3d051253 (ARM64: dts: mt8173: Add CPU OPP, clock and regulator supply properties) in one of Raphael's trees: > arm64-allmodconfig > Error: ../arch/arm64/boot/dts/mediatek/mt8173.dtsi:132.24-25 syntax error > Error: ../arch/arm64/boot/dts/mediatek/mt8173.dtsi:132.24-25 syntax error > arm64-defconfig > Error: ../arch/arm64/boot/dts/mediatek/mt8173.dtsi:132.24-25 syntax error which is failing because at least CLK_INFRA_CA53SEL is used but never defined, presumably there is some dependency which wasn't integrated. Normally we merge DT changes via the architecture to help avoid these issues. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160104/6ae7e456/attachment-0001.sig> ^ permalink raw reply [flat|nested] 5+ messages in thread
* next-20160104 build: 3 failures 15 warnings (next-20160104) 2016-01-04 15:35 ` next-20160104 build: 3 failures 15 warnings (next-20160104) Mark Brown @ 2016-01-05 1:04 ` Rafael J. Wysocki 0 siblings, 0 replies; 5+ messages in thread From: Rafael J. Wysocki @ 2016-01-05 1:04 UTC (permalink / raw) To: linux-arm-kernel On 1/4/2016 4:35 PM, Mark Brown wrote: > On Mon, Jan 04, 2016 at 12:12:20PM +0000, Build bot for Mark Brown wrote: > > Today's linux-next fails to build for arm64 due to 44d3d051253 (ARM64: > dts: mt8173: Add CPU OPP, clock and regulator supply properties) Thanks for letting me know, I've dropped this one. > in one of Raphael's trees: > >> arm64-allmodconfig >> Error: ../arch/arm64/boot/dts/mediatek/mt8173.dtsi:132.24-25 syntax error >> Error: ../arch/arm64/boot/dts/mediatek/mt8173.dtsi:132.24-25 syntax error >> arm64-defconfig >> Error: ../arch/arm64/boot/dts/mediatek/mt8173.dtsi:132.24-25 syntax error > which is failing because at least CLK_INFRA_CA53SEL is used but never > defined, presumably there is some dependency which wasn't integrated. > Normally we merge DT changes via the architecture to help avoid these > issues. Yes, that would be better. Thanks, Rafael ^ permalink raw reply [flat|nested] 5+ messages in thread
* next-20160104 build: 3 failures 15 warnings (next-20160104) [not found] <E1aG3zo-0000gt-2t@optimist> 2016-01-04 15:35 ` next-20160104 build: 3 failures 15 warnings (next-20160104) Mark Brown @ 2016-01-04 16:50 ` Mark Brown 2016-01-04 22:07 ` Arnd Bergmann 1 sibling, 1 reply; 5+ messages in thread From: Mark Brown @ 2016-01-04 16:50 UTC (permalink / raw) To: linux-arm-kernel On Mon, Jan 04, 2016 at 12:12:20PM +0000, Build bot for Mark Brown wrote: Today's linux-next fails to build an arm allmodconfig (and probably also at least arm64 though other errors prevent that getting to linking currently) due to: | drivers/built-in.o: In function `dtsec_restart_autoneg': | :(.text+0x30f86c): undefined reference to `mdiobus_read' | :(.text+0x30f89c): undefined reference to `mdiobus_write' | drivers/built-in.o: In function `dtsec_init': | :(.text+0x31008c): undefined reference to `mdiobus_write' | :(.text+0x3100b4): undefined reference to `mdiobus_write' | :(.text+0x3100dc): undefined reference to `mdiobus_write' | :(.text+0x310128): undefined reference to `mdiobus_write' | drivers/built-in.o::(.text+0x310150): more undefined references to `mdiobus_write' follow | drivers/built-in.o: In function `dtsec_config': | :(.text+0x310804): undefined reference to `of_phy_find_device' and various other linker errors caused by the fact that the new fman driver uses PHYLIB but does not depend on or select it. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160104/187e4c0e/attachment.sig> ^ permalink raw reply [flat|nested] 5+ messages in thread
* next-20160104 build: 3 failures 15 warnings (next-20160104) 2016-01-04 16:50 ` Mark Brown @ 2016-01-04 22:07 ` Arnd Bergmann 2016-01-04 22:44 ` Mark Brown 0 siblings, 1 reply; 5+ messages in thread From: Arnd Bergmann @ 2016-01-04 22:07 UTC (permalink / raw) To: linux-arm-kernel On Monday 04 January 2016 16:50:25 Mark Brown wrote: > On Mon, Jan 04, 2016 at 12:12:20PM +0000, Build bot for Mark Brown wrote: > > Today's linux-next fails to build an arm allmodconfig (and probably also > at least arm64 though other errors prevent that getting to linking > currently) due to: > > | drivers/built-in.o: In function `dtsec_restart_autoneg': > | :(.text+0x30f86c): undefined reference to `mdiobus_read' > | :(.text+0x30f89c): undefined reference to `mdiobus_write' > | drivers/built-in.o: In function `dtsec_init': > | :(.text+0x31008c): undefined reference to `mdiobus_write' > | :(.text+0x3100b4): undefined reference to `mdiobus_write' > | :(.text+0x3100dc): undefined reference to `mdiobus_write' > | :(.text+0x310128): undefined reference to `mdiobus_write' > | drivers/built-in.o::(.text+0x310150): more undefined references to `mdiobus_write' follow > | drivers/built-in.o: In function `dtsec_config': > | :(.text+0x310804): undefined reference to `of_phy_find_device' > > and various other linker errors caused by the fact that the new fman > driver uses PHYLIB but does not depend on or select it. This is the patch I submitted for the problem. I don't think that simply adding the 'select' would be a good idea because that would force PHYLIB builtin for allmodconfig. Arnd commit 609a5b98a4b703a4fba8becb7ffb2aa1859c4164 Author: Arnd Bergmann <arnd@arndb.de> Date: Fri Jan 1 13:24:03 2016 +0100 [SUBMITTED] fsl/fman: allow modular build ARM allmodconfig fails because of the addition of the FMAN driver: drivers/built-in.o: In function `dtsec_restart_autoneg': binder.c:(.text+0x173328): undefined reference to `mdiobus_read' binder.c:(.text+0x173348): undefined reference to `mdiobus_write' drivers/built-in.o: In function `dtsec_config': binder.c:(.text+0x173d24): undefined reference to `of_phy_find_device' drivers/built-in.o: In function `init_phy': binder.c:(.text+0x1763b0): undefined reference to `of_phy_connect' drivers/built-in.o: In function `stop': binder.c:(.text+0x176014): undefined reference to `phy_stop' drivers/built-in.o: In function `start': binder.c:(.text+0x176078): undefined reference to `phy_start' The reason is that the driver uses PHYLIB, but that is a loadable module here, and fman itself is built-in. This patch makes it possible to configure fman as a module as well so we don't change the status of PHYLIB in an allmodconfig kernel, and it adds a 'select PHYLIB' statement to ensure that phylib is always built-in when fman is. The driver uses "builtin_platform_driver(fman_driver);", which means it cannot be unloaded, but it's still possible to have it as a loadable module that gets loaded once and never removed. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Fixes: 5adae51a64b8 ("fsl/fman: Add FMan MURAM support") diff --git a/drivers/net/ethernet/freescale/fman/Kconfig b/drivers/net/ethernet/freescale/fman/Kconfig index 66b729692b48..79b7c84b7869 100644 --- a/drivers/net/ethernet/freescale/fman/Kconfig +++ b/drivers/net/ethernet/freescale/fman/Kconfig @@ -1,7 +1,8 @@ config FSL_FMAN - bool "FMan support" + tristate "FMan support" depends on FSL_SOC || COMPILE_TEST select GENERIC_ALLOCATOR + select PHYLIB default n help Freescale Data-Path Acceleration Architecture Frame Manager ^ permalink raw reply related [flat|nested] 5+ messages in thread
* next-20160104 build: 3 failures 15 warnings (next-20160104) 2016-01-04 22:07 ` Arnd Bergmann @ 2016-01-04 22:44 ` Mark Brown 0 siblings, 0 replies; 5+ messages in thread From: Mark Brown @ 2016-01-04 22:44 UTC (permalink / raw) To: linux-arm-kernel On Mon, Jan 04, 2016 at 11:07:41PM +0100, Arnd Bergmann wrote: > On Monday 04 January 2016 16:50:25 Mark Brown wrote: > > On Mon, Jan 04, 2016 at 12:12:20PM +0000, Build bot for Mark Brown wrote: > > and various other linker errors caused by the fact that the new fman > > driver uses PHYLIB but does not depend on or select it. > This is the patch I submitted for the problem. I don't think that simply > adding the 'select' would be a good idea because that would force PHYLIB > builtin for allmodconfig. Indeed, that was why I held off on my own patch - I wanted to go back and try to understand why we were using a bool there. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160104/8dd9e541/attachment.sig> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-01-05 1:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1aG3zo-0000gt-2t@optimist>
2016-01-04 15:35 ` next-20160104 build: 3 failures 15 warnings (next-20160104) Mark Brown
2016-01-05 1:04 ` Rafael J. Wysocki
2016-01-04 16:50 ` Mark Brown
2016-01-04 22:07 ` Arnd Bergmann
2016-01-04 22:44 ` Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).