From: zyw@rock-chips.com (Chris Zhong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6.3 4/6] drm: rockchip: Support Synopsys DW MIPI DSI
Date: Wed, 6 Jan 2016 12:16:52 +0800 [thread overview]
Message-ID: <568C9534.3050700@rock-chips.com> (raw)
In-Reply-To: <568C7258.3010104@rock-chips.com>
Hi Mark
On 01/06/2016 09:48 AM, Mark yao wrote:
> On 2015?12?23? 11:43, Chris Zhong wrote:
>> +static int dw_mipi_dsi_register(struct drm_device *drm,
>> + struct dw_mipi_dsi *dsi)
>> +{
>> + struct drm_encoder *encoder = &dsi->encoder;
>> + struct drm_connector *connector = &dsi->connector;
>> + struct device *dev = dsi->dev;
>> + int ret;
>> +
>> + encoder->possible_crtcs = drm_of_find_possible_crtcs(drm,
>> + dev->of_node);
>> + /*
>> + * If we failed to find the CRTC(s) which this encoder is
>> + * supposed to be connected to, it's because the CRTC has
>> + * not been registered yet. Defer probing, and hope that
>> + * the required CRTC is added later.
>> + */
>> + if (encoder->possible_crtcs == 0)
>> + return -EPROBE_DEFER;
>> +
>> + drm_encoder_helper_add(&dsi->encoder,
>> + &dw_mipi_dsi_encoder_helper_funcs);
>> + ret = drm_encoder_init(drm, &dsi->encoder,
>> &dw_mipi_dsi_encoder_funcs,
>> + DRM_MODE_ENCODER_DSI);
>> + if (ret) {
>> + dev_err(dev, "Failed to initialize encoder with drm\n");
>> + return ret;
>> + }
>> +
>> + drm_connector_helper_add(connector,
>> + &dw_mipi_dsi_connector_helper_funcs);
>> +
>> + drm_connector_init(drm, &dsi->connector,
>> + &dw_mipi_dsi_atomic_connector_funcs,
>> + DRM_MODE_CONNECTOR_DSI);
>> +
> Hi Chris
>
> I try to pick your patches, but found following issues:
>
> drivers/gpu/drm/rockchip/dw-mipi-dsi.c: ????dw_mipi_dsi_register??:
> drivers/gpu/drm/rockchip/dw-mipi-dsi.c:1024:5: ??? ?????
> ?drm_encoder_init??????
> include/drm/drm_crtc.h:2220:5: ??? ????
> make[4]: *** [drivers/gpu/drm/rockchip/dw-mipi-dsi.o] ?? 1
>
> Can you rebase to newest Dave's drm-next and fix this problem?
Thanks Mark.
I have post the v7 serial, fix this this compile err and modify the
config to tristate for modules build
>
> Thanks.
>
next prev parent reply other threads:[~2016-01-06 4:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 10:10 [PATCH v6 0/6] Add mipi dsi support for rk3288 Chris Zhong
2015-12-16 10:10 ` [PATCH v6 1/6] drm/rockchip: return a true clock rate to adjusted_mode Chris Zhong
2015-12-16 10:10 ` [PATCH v6 3/6] Documentation: dt-bindings: Add bindings for rk3288 DW MIPI DSI driver Chris Zhong
2015-12-16 10:10 ` [PATCH v6 4/6] drm: rockchip: Support Synopsys DW MIPI DSI Chris Zhong
2015-12-18 9:47 ` [PATCH v6.1 " Chris Zhong
2015-12-18 10:18 ` Mark yao
2015-12-22 6:58 ` [PATCH v6.2 " Chris Zhong
2015-12-23 3:43 ` [PATCH v6.3 " Chris Zhong
2015-12-24 0:55 ` Mark yao
2016-01-06 1:48 ` Mark yao
2016-01-06 4:16 ` Chris Zhong [this message]
2016-01-06 2:04 ` Mark yao
2015-12-16 10:10 ` [PATCH v6 5/6] ARM: dts: rockchip: add rk3288 mipi_dsi nodes Chris Zhong
2015-12-16 10:10 ` [PATCH v6 6/6] ARM: dts: rockchip: add support mipi panel tv080wum-nl0 Chris Zhong
2015-12-17 9:29 ` [PATCH v6 0/6] Add mipi dsi support for rk3288 Heiko Stübner
2015-12-18 9:54 ` Chris Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568C9534.3050700@rock-chips.com \
--to=zyw@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).