From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9684C77B73 for ; Thu, 18 May 2023 20:11:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nehk76dVuz8F9IOLOD7LYaQcc/lBMY6Xuf254nMPJZ0=; b=2SlXQUyu7XeX5h sPkk+C2qZOmf05LUxkpu73MGs6ePGTMY5FLH+rfJ5vJEzG78BqcZRadb/jHvoPEn+zoj2H5k0EZX/ +r1chqvsgL3IlG4AYsShxLANHpustawpEhl/wmknsRNO2ujl4T23akxD2FI1h3wnpS3UHqCwzgpkN d8FS21abUIcgR1JVrAjlMkJvLolf3GRg7uModADsmmrZita5wrlnIv418wFUSNMTYovgBOYdut7CB 46NX/jhP1qNRrtyMJpSqk8dBpfXaBKTDmjAG8UZIApynyP/7hvBHQw9oQalt3Epoz0GMoQYU0J819 TOTgFB6TakNd+j/4NX6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pzjxj-00E46V-0I; Thu, 18 May 2023 20:10:59 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pzjxg-00E45x-0z for linux-arm-kernel@lists.infradead.org; Thu, 18 May 2023 20:10:57 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0B75E61049; Thu, 18 May 2023 20:10:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62062C433EF; Thu, 18 May 2023 20:10:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684440654; bh=8ADVUlv2ISWPlpxPmf/ySUg5Jb+Bc1bMYOm2326rqxY=; h=In-Reply-To:References:Subject:From:Cc:List-Id:To:Date:From; b=O7MAkrBessqkZ7/t1VwHglElnZ/75v2/qwNN/Q2RYwXAvBv32J/MVlhEQhKHg3YXe WvVkBvySbmDqoFI0OiuMI8cWqVKCapy/Wz6LtMeBR7s13Sj0RrgMOjY0GGKwv/Kyr6 IWd+yYP4Ip7bNorNaGpFrprAR9itldhPNfWaLwzqBaCdtEUE8GZnxqICgdAV5yF+BD fch/9qkiBEXJFR8yrI7fPx4QH/kLoyLYzaRcpmUP2OASsEckcPdzOLHD/mfEk1hZIY mm6KBC/FR+klYbeqGLe98JlB96Lrc9TkpGmX4C0X9YMBfAV0vk8e9Zoj0r/yJnV7Jm yg6XU/j1UKMMQ== Message-ID: <568f74a4667711a8b7c852d88f6f5669.sboyd@kernel.org> MIME-Version: 1.0 In-Reply-To: <20230516153109.514251-11-arnd@kernel.org> References: <20230516153109.514251-1-arnd@kernel.org> <20230516153109.514251-11-arnd@kernel.org> Subject: Re: [PATCH 10/13] ARM: pxa: fix missing-prototypes warnings From: Stephen Boyd Cc: Arnd Bergmann , Russell King , Bartosz Golaszewski , Hartley Sweeten , Alexander Sverdlin , Andre Przywara , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Viresh Kumar , Shiraz Hashim , Sudeep Holla , Lorenzo Pieralisi , Linus Walleij , Michael Turquette , Greg Kroah-Hartman , Alan Stern , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-usb@vger.kernel.org To: Arnd Bergmann , soc@kernel.org Date: Thu, 18 May 2023 13:10:52 -0700 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230518_131056_440675_86F3C268 X-CRM114-Status: GOOD ( 14.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Arnd Bergmann (2023-05-16 08:31:06) > From: Arnd Bergmann > > The PXA platform has a number of configurations that end up with > a warning like these when building with W=1: > > drivers/hwmon/max1111.c:83:5: error: no previous prototype for 'max1111_read_channel' [-Werror=missing-prototypes] > arch/arm/mach-pxa/reset.c:86:6: error: no previous prototype for 'pxa_restart' [-Werror=missing-prototypes] > arch/arm/mach-pxa/mfp-pxa2xx.c:254:5: error: no previous prototype for 'keypad_set_wake' [-Werror=missing-prototypes] > drivers/clk/pxa/clk-pxa25x.c:70:14: error: no previous prototype for 'pxa25x_get_clk_frequency_khz' [-Werror=missing-prototypes] > drivers/clk/pxa/clk-pxa25x.c:325:12: error: no previous prototype for 'pxa25x_clocks_init' [-Werror=missing-prototypes] > drivers/clk/pxa/clk-pxa27x.c:74:14: error: no previous prototype for 'pxa27x_get_clk_frequency_khz' [-Werror=missing-prototypes] > drivers/clk/pxa/clk-pxa27x.c:102:6: error: no previous prototype for 'pxa27x_is_ppll_disabled' [-Werror=missing-prototypes] > drivers/clk/pxa/clk-pxa27x.c:470:12: error: no previous prototype for 'pxa27x_clocks_init' [-Werror=missing-prototypes] > arch/arm/mach-pxa/pxa27x.c:44:6: error: no previous prototype for 'pxa27x_clear_otgph' [-Werror=missing-prototypes] > arch/arm/mach-pxa/pxa27x.c:58:6: error: no previous prototype for 'pxa27x_configure_ac97reset' [-Werror=missing-prototypes] > arch/arm/mach-pxa/spitz_pm.c:170:15: error: no previous prototype for 'spitzpm_read_devdata' [-Werror=missing-prototypes] > > The problem is that there is a declaration for each of these, but > it's only seen by the caller and not the callee. Moving these > into appropriate header files ensures that both use the same > calling conventions and it avoids the warnings. > > Signed-off-by: Arnd Bergmann > --- Acked-by: Stephen Boyd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel