From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] acpi: Fix proper return code for function acpi_gsi_to_irq
Date: Tue, 12 Jan 2016 18:59:36 +0000 [thread overview]
Message-ID: <56954D18.1010306@arm.com> (raw)
In-Reply-To: <1446857519-5908-2-git-send-email-lho@apm.com>
On 07/11/15 00:51, Loc Ho wrote:
> The function acpi_gsi_to_irq should returns 0 on success as upper function
> caller expect an 0 for sucesss.
I have to ask: why do you feel the need to change an API that behaves
like the rest of the IRQ allocation functions (at least when it comes to
its return value)?
0 is defined as an invalid interrupt, and I wish it stayed that way.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2016-01-12 18:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-07 0:51 [PATCH v3 0/2] acpi: apei: Bug fix to enable APEI support for ARMv8 Loc Ho
2015-11-07 0:51 ` [PATCH v3 1/2] acpi: Fix proper return code for function acpi_gsi_to_irq Loc Ho
2016-01-10 11:07 ` Borislav Petkov
2016-01-11 22:04 ` Tuan Phan
2016-01-11 22:13 ` Borislav Petkov
2016-01-11 22:41 ` Tuan Phan
2016-01-12 14:36 ` Borislav Petkov
2016-01-12 18:26 ` Tuan Phan
2016-01-12 18:32 ` Borislav Petkov
2016-01-12 18:46 ` Tuan Phan
2016-01-12 19:21 ` Borislav Petkov
2016-01-12 18:59 ` Marc Zyngier [this message]
2016-01-12 19:13 ` Tuan Phan
2016-01-12 19:32 ` Marc Zyngier
2016-01-12 20:01 ` Tuan Phan
2016-01-13 8:40 ` Marc Zyngier
2015-11-07 0:51 ` [PATCH v3 2/2] acpi: apei: Enable APEI multiple GHES source to share an single external IRQ Loc Ho
2016-01-09 0:30 ` [PATCH v3 0/2] acpi: apei: Bug fix to enable APEI support for ARMv8 Loc Ho
2016-01-10 11:08 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56954D18.1010306@arm.com \
--to=marc.zyngier@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).