From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 140B7C4332F for ; Mon, 14 Nov 2022 06:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oL1Ol+JCnwTLDV3v2SeNNcHcJGghOeNRmasaOYM5Bro=; b=Be5ywbH5zJM9sz CC67DnLd5Ei8s4Rio5O/D1XH5fYkNDkLWXOX5ARx9dyQGErBSHY+42/V3zWa/4zzjx3/yr4NkEBpm lMj8hCfNeTaFw+Z5aNKQsXXiAX8d5rf0xhbk0v3F3d8iRmzoAS7tYwZ9GRON1xZur4AORPvZp7Ff5 izFn8K1Pnn2KOb0XOJ958RYDJDB1k7M5E0QVzwXuhN9M0pWvX4YL4m1g/fC4tkm1Et/8gct3y3Rih 7MOjtaQWtHcRpl7uCpIQQtkB/N4bE3dNfMmlA4k7VEfhaNbN/xZuurkNezrjERuWusG/tZFdroBHV lE/7LRpQlveQd+71vKaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouT3F-00GIN4-UI; Mon, 14 Nov 2022 06:34:38 +0000 Received: from out30-44.freemail.mail.aliyun.com ([115.124.30.44]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouT3B-00GIHU-Pp; Mon, 14 Nov 2022 06:34:36 +0000 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R281e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=18;SR=0;TI=SMTPD_---0VUiKOlR_1668407663; Received: from 30.97.48.62(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VUiKOlR_1668407663) by smtp.aliyun-inc.com; Mon, 14 Nov 2022 14:34:25 +0800 Message-ID: <5699ed28-bdad-f9ab-44b6-e957c00745f9@linux.alibaba.com> Date: Mon, 14 Nov 2022 14:34:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 14/18] mfd: sprd-sc27xx-spi: Replace irqchip mask_invert with unmask_base To: Aidan MacDonald , lee@kernel.org Cc: mani@kernel.org, cristian.ciocaltea@gmail.com, wens@csie.org, tharvey@gateworks.com, cw00.choi@samsung.com, krzysztof.kozlowski@linaro.org, brgl@bgdev.pl, mazziesaccount@gmail.com, orsonzhai@gmail.com, zhang.lyra@gmail.com, jernej.skrabec@gmail.com, samuel@sholland.org, linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev References: <20221112151835.39059-1-aidanmacdonald.0x0@gmail.com> <20221112151835.39059-15-aidanmacdonald.0x0@gmail.com> From: Baolin Wang In-Reply-To: <20221112151835.39059-15-aidanmacdonald.0x0@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221113_223434_062698_D75E97C9 X-CRM114-Status: UNSURE ( 9.51 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/12/2022 11:18 PM, Aidan MacDonald wrote: > Remove use of the deprecated mask_invert flag. Inverted mask > registers (where a '1' bit enables an IRQ) can be described more > directly as an unmask register. > > Signed-off-by: Aidan MacDonald LGTM. Thanks. Reviewed-by: Baolin Wang > --- > drivers/mfd/sprd-sc27xx-spi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c > index d05a47c5187f..a4a9b81a952b 100644 > --- a/drivers/mfd/sprd-sc27xx-spi.c > +++ b/drivers/mfd/sprd-sc27xx-spi.c > @@ -181,11 +181,10 @@ static int sprd_pmic_probe(struct spi_device *spi) > ddata->irq_chip.name = dev_name(&spi->dev); > ddata->irq_chip.status_base = > pdata->irq_base + SPRD_PMIC_INT_MASK_STATUS; > - ddata->irq_chip.mask_base = pdata->irq_base + SPRD_PMIC_INT_EN; > + ddata->irq_chip.unmask_base = pdata->irq_base + SPRD_PMIC_INT_EN; > ddata->irq_chip.ack_base = 0; > ddata->irq_chip.num_regs = 1; > ddata->irq_chip.num_irqs = pdata->num_irqs; > - ddata->irq_chip.mask_invert = true; > > ddata->irqs = devm_kcalloc(&spi->dev, > pdata->num_irqs, sizeof(struct regmap_irq), _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel