linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller
Date: Wed, 20 Jan 2016 16:23:13 +0000	[thread overview]
Message-ID: <569FB471.8000909@arm.com> (raw)
In-Reply-To: <yw1xr3hcqlix.fsf@unicorn.mansr.com>

On 20/01/16 16:10, M?ns Rullg?rd wrote:
> Marc Zyngier <marc.zyngier@arm.com> writes:
> 
>>> +	if (of_property_read_u32(node, "reg", &ctl))
>>> +		panic("%s: failed to get reg base", node->name);
>>> +
>>> +	chip = kzalloc(sizeof(*chip), GFP_KERNEL);
>>> +	chip->ctl = ctl;
>>> +	chip->base = base;
> 
> As I said before, this assumes the outer DT node uses a ranges
> property.  Normally reg properties work the same whether they specify an
> offset within an outer "ranges" or have a full address directly.  It
> would be easy enough to make this work with either, so I don't see any
> reason not to.

Yup, that is a good point. I guess Marc can address this in the next
round, since we need a DT binding anyway.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2016-01-20 16:23 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-18 12:56 [RFC PATCH v2] irqchip: Add support for Tango interrupt controller Marc Gonzalez
2016-01-18 13:04 ` Måns Rullgård
2016-01-18 15:57 ` Marc Gonzalez
2016-01-18 16:44   ` [RFC PATCH v3] " Marc Gonzalez
2016-01-20 16:04     ` Marc Zyngier
2016-01-20 16:10       ` Måns Rullgård
2016-01-20 16:23         ` Marc Zyngier [this message]
2016-01-20 16:25           ` Måns Rullgård
2016-01-20 16:36             ` Marc Gonzalez
2016-01-20 16:38               ` Måns Rullgård
2016-01-20 16:43                 ` Marc Gonzalez
2016-01-20 18:09                   ` Måns Rullgård
2016-01-22 15:58                     ` Marc Gonzalez
2016-01-22 16:35                       ` Måns Rullgård
2016-01-22 16:37                         ` Marc Gonzalez
2016-01-22 16:39                           ` Måns Rullgård
2016-01-22 16:45                             ` Marc Gonzalez
2016-01-22 16:49                               ` Måns Rullgård
2016-01-20 16:24         ` Marc Gonzalez
2016-01-20 16:26           ` Måns Rullgård
2016-01-20 17:02           ` Mark Rutland
2016-01-20 17:05             ` Måns Rullgård
2016-01-20 17:05             ` Marc Gonzalez
2016-01-20 17:06               ` Måns Rullgård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569FB471.8000909@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).