From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5707C00A89 for ; Mon, 2 Nov 2020 08:41:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17EEF2074F for ; Mon, 2 Nov 2020 08:41:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LL8p9D8b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17EEF2074F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6hcL7uEIBeruEZl3X3DrsPv24IgvfdJZJ78ApTzR84c=; b=LL8p9D8bwyPIFxn2rrlIGIQrR VnqAtyl6Okm00TAVatdiTrcrbXhctGkIEJuo/JC4PpqXZ9CIo0YMS48EXRKSB6RB7u86y0qxbjtYp /npuBpruDg3OxKDT8GGLvN2LKwDMKVTqAZ3e1YET5cC7kFof37lT+h4+e6RZT26GOrDPEfBO/uLYr O0ZjwC06g4rjBVb16gLVaeLqX3njOeza6gmioTRqNXRzTn6/nla1pA9eoKnn/mCCqFyEE846lKNEQ 08hzKa2uCP0WFD7hXoRymz/x9KEfuYwg9XuD0i/0u5eenM7S3T12u/rXYra/UMxm30/XADCtAUc/b 9vxQu1ZYw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZVOl-0007ps-Nj; Mon, 02 Nov 2020 08:41:07 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZVOj-0007ot-Mj for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 08:41:06 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1C524101E; Mon, 2 Nov 2020 00:41:01 -0800 (PST) Received: from [10.57.13.99] (unknown [10.57.13.99]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 71DE23F718; Mon, 2 Nov 2020 00:40:58 -0800 (PST) Subject: Re: [PATCH 1/4] dt-bindings: opp: Introduce opp-sustainable bindings To: Rob Herring References: <20201028140847.1018-1-lukasz.luba@arm.com> <20201028140847.1018-2-lukasz.luba@arm.com> <20201030193427.GA4186428@bogus> From: Lukasz Luba Message-ID: <569a07c0-be6b-7ffe-2920-accea1f932f0@arm.com> Date: Mon, 2 Nov 2020 08:40:57 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20201030193427.GA4186428@bogus> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_034105_859901_7D663BA7 X-CRM114-Status: GOOD ( 23.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, devicetree@vger.kernel.org, daniel.lezcano@linaro.org, linux-pm@vger.kernel.org, sboyd@kernel.org, vireshk@kernel.org, rafael@kernel.org, linux-kernel@vger.kernel.org, sudeep.holla@arm.com, Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, On 10/30/20 7:34 PM, Rob Herring wrote: > On Wed, Oct 28, 2020 at 02:08:44PM +0000, Lukasz Luba wrote: >> Add opp-sustainable as an additional property in the OPP node to describe >> the sustainable performance level of the device. This will help to >> estimate the sustainable performance of the whole system. >> >> Signed-off-by: Lukasz Luba >> --- >> Documentation/devicetree/bindings/opp/opp.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt >> index 9847dfeeffcb..cd01028de305 100644 >> --- a/Documentation/devicetree/bindings/opp/opp.txt >> +++ b/Documentation/devicetree/bindings/opp/opp.txt >> @@ -154,6 +154,10 @@ Optional properties: >> - opp-suspend: Marks the OPP to be used during device suspend. If multiple OPPs >> in the table have this, the OPP with highest opp-hz will be used. >> >> +- opp-sustainable: Marks the OPP as sustainable. This property can be used for >> + estimating sustainable performance of the whole system. If multiple OPPs in >> + the table have this, the OPP with highest opp-hz will be used. >> + > > Isn't this just the inverse of the turbo? or boost? flag we already > have? True, it could be possible to use those flags. Then a function which returns one OPP below, would be 'sustainable'. I've already suggested to skip binding and only have get/set functions for OPP framework to mark 'sustainable' level, but Viresh is against. We have discussed this new opp sustainable with Viresh and since it would be only used by IPA but the definition is a bit blurry, we decided to drop this series. Maybe in future when there will be another user, we will come back to this. I am going to use Energy Model and mark the em_perf_state as sustained. > > Couldn't this be learned? I ran at this frequency and then overheated. > That could be dependent on ambient temperatures or dust build up on > fans/heatsink. Yes it could be learned. IPA tries to do that for different workloads, but it needs some starting conditions (coefficients and sustainable power) to converge in short time. Sustainable power is currently estimated based on lowest OPP. With that new 'sustainable' flag, it would be much easier for IPA to converge. Regards, Lukasz > > Rob > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel