From: santosh.shilimkar@oracle.com (santosh.shilimkar at oracle.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: make virt_to_idmap() return unsigned long
Date: Tue, 26 Jan 2016 20:27:52 -0800 [thread overview]
Message-ID: <56A84748.3040108@oracle.com> (raw)
In-Reply-To: <E1aO8F2-00074N-E8@rmk-PC.arm.linux.org.uk>
On 1/26/16 10:21 AM, Russell King wrote:
> Make virt_to_idmap() return an unsigned long rather than phys_addr_t.
>
> Returning phys_addr_t here makes no sense, because the definition of
> virt_to_idmap() is that it shall return a physical address which maps
> identically with the virtual address. Since virtual addresses are
> limited to 32-bit, identity mapped physical addresses are as well.
>
> Almost all users already had an implicit narrowing cast to unsigned long
> so let's make this official and part of this interface.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
Looks correct to me.
Vitaly,
Could you please try out this patch and see everything continue to
work ?
Regards,
Santosh
next prev parent reply other threads:[~2016-01-27 4:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 18:21 [PATCH 1/2] ARM: make virt_to_idmap() return unsigned long Russell King
2016-01-27 4:27 ` santosh.shilimkar at oracle.com [this message]
2016-02-01 15:20 ` Russell King - ARM Linux
2016-02-01 17:01 ` Vitaly Andrianov
2016-02-01 17:10 ` santosh shilimkar
2016-02-01 17:31 ` Russell King - ARM Linux
2016-02-01 17:55 ` santosh.shilimkar at oracle.com
2016-02-03 0:09 ` santosh shilimkar
2016-02-03 14:14 ` Grygorii Strashko
2016-02-03 15:43 ` Vitaly Andrianov
2016-02-03 19:59 ` Russell King - ARM Linux
2016-02-04 11:53 ` Grygorii Strashko
2016-02-08 17:10 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A84748.3040108@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).