From: dirk.behme@gmail.com (Dirk Behme)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drivers/perf: arm_pmu: make info messages more verbose
Date: Mon, 1 Feb 2016 17:43:23 +0100 [thread overview]
Message-ID: <56AF8B2B.6020705@gmail.com> (raw)
In-Reply-To: <1452586940-20137-1-git-send-email-dirk.behme@de.bosch.com>
On 12.01.2016 09:22, Dirk Behme wrote:
> On a big.LITTLE system e.g. with Cortex A57 and A53 in case not all cores
> are online at PMU probe time we might get
>
> hw perfevents: failed to probe PMU!
> hw perfevents: failed to register PMU devices!
>
> making it unclear which cores failed, here.
>
> Add the name of the PMU which failed resulting in a more verbose and
> helpful message
>
> hw perfevents: armv8_cortex_a53: failed to probe PMU!
> hw perfevents: armv8_cortex_a53: failed to register PMU devices!
>
> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
> ---
> drivers/perf/arm_pmu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
> index be3755c..fc1f06f 100644
> --- a/drivers/perf/arm_pmu.c
> +++ b/drivers/perf/arm_pmu.c
> @@ -904,7 +904,7 @@ int arm_pmu_device_probe(struct platform_device *pdev,
> }
>
> if (ret) {
> - pr_info("failed to probe PMU!\n");
> + pr_info("%s: failed to probe PMU!\n", pmu->name);
> goto out_free;
> }
>
> @@ -921,7 +921,7 @@ int arm_pmu_device_probe(struct platform_device *pdev,
> out_destroy:
> cpu_pmu_destroy(pmu);
> out_free:
> - pr_info("failed to register PMU devices!\n");
> + pr_info("%s: failed to register PMU devices!\n", pmu->name);
> kfree(pmu);
> return ret;
> }
Any comments on this?
If not, how to get this applied?
Best regards
Dirk
next prev parent reply other threads:[~2016-02-01 16:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 8:22 [PATCH] drivers/perf: arm_pmu: make info messages more verbose Dirk Behme
2016-02-01 16:43 ` Dirk Behme [this message]
2016-02-01 16:49 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AF8B2B.6020705@gmail.com \
--to=dirk.behme@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).