From mboxrd@z Thu Jan 1 00:00:00 1970 From: timur@codeaurora.org (Timur Tabi) Date: Thu, 4 Feb 2016 10:37:38 -0600 Subject: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver In-Reply-To: <20160204163101.GH17257@arm.com> References: <1454519923-25230-1-git-send-email-fu.wei@linaro.org> <1454519923-25230-5-git-send-email-fu.wei@linaro.org> <20160204163101.GH17257@arm.com> Message-ID: <56B37E52.300@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Will Deacon wrote: >> +static int sbsa_gwdt_keepalive(struct watchdog_device *wdd) >> >+{ >> >+ struct sbsa_gwdt *gwdt = to_sbsa_gwdt(wdd); >> >+ >> >+ /* >> >+ * Writing WRR for an explicit watchdog refresh. >> >+ * You can write anyting(like 0xc0ffee). >> >+ */ >> >+ writel(0xc0ffee, gwdt->refresh_base + SBSA_GWDT_WRR); >> >+ >> >+ return 0; >> >+} > You might get in trouble for that. 0xd09f00d is probably less poisonous. > > http://www.petpoisonhelpline.com/poison/caffeine/ Any reason why we can't just keep it simple and write 0?