From mboxrd@z Thu Jan 1 00:00:00 1970 From: dave.long@linaro.org (David Long) Date: Tue, 9 Feb 2016 15:55:02 -0500 Subject: [PATCH v3 0/2] Consolidate redundant register/stack access code In-Reply-To: <20160209094526.GB25268@gmail.com> References: <1454996337-7935-1-git-send-email-dave.long@linaro.org> <1455010600.13384.3.camel@ellerman.id.au> <20160209094526.GB25268@gmail.com> Message-ID: <56BA5226.3090105@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/09/2016 04:45 AM, Ingo Molnar wrote: > > * Michael Ellerman wrote: > >> On Tue, 2016-02-09 at 00:38 -0500, David Long wrote: >> >>> From: "David A. Long" >>> >>> Move duplicate and functionally equivalent code for accessing registers >>> and stack (CONFIG_HAVE_REGS_AND_STACK_ACCESS_API) from arch subdirs into >>> common kernel files. >>> >>> I'm sending this out again (with updated distribution list) because v2 >>> just never got pulled in, even though I don't think there were any >>> outstanding issues. >> >> A big cross arch patch like this would often get taken by Andrew Morton, but >> AFAICS you didn't CC him - so I just added him, perhaps he'll pick it up for >> us :D > > The other problem is that the second patch is commingling changes to 6 separate > architectures: > > 16 files changed, 106 insertions(+), 343 deletions(-) > > that should probably be 6 separate patches. Easier to review, easier to bisect to, > easier to revert, etc. > > Thanks, > > Ingo > I see your point but I'm not sure it could have been broken into separate successive patches that would each build for all architectures. -dl