linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] irqchip/gic-v3-its: Fix double EOIR write for LPI in EOImode==1
Date: Thu, 11 Feb 2016 15:45:26 +0000	[thread overview]
Message-ID: <56BCAC96.7040509@arm.com> (raw)
In-Reply-To: <1455197933-26141-1-git-send-email-ashoks@broadcom.com>

On 11/02/16 13:38, Ashok Kumar wrote:
> CPU receives SError exception EOI1_NO_INTS_ACTIVE when EOIR
> is written twice in gic_handle_irq and in its_eoi_irq for a
> single LPI in EOImode == 1.
> 
> Now irq_eoi of its_irq_chip calls parent irqchip's(gic_eoimode1_chip/gic_chip)
> irq_eoi handler which handles EOImode 0 and 1 separately.
> 
> This is introduced by
> commit 0b996fd35957a ("irqchip/GICv3: Convert to EOImode == 1")
> 
> Signed-off-by: Ashok Kumar <ashoks@broadcom.com>

Ah, really good catch!

Acked-by: Marc Zyngier <marc.zyngier@arm.com>

I'll try to queue that for -rc4, but it is more likely that it will land
in -rc5...

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

      reply	other threads:[~2016-02-11 15:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-11 13:38 [PATCH] irqchip/gic-v3-its: Fix double EOIR write for LPI in EOImode==1 Ashok Kumar
2016-02-11 15:45 ` Marc Zyngier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56BCAC96.7040509@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).